NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

package/luajit: drop useless post-extract hook

Browse Source 
Since version 2.1, LuaJIT follows a rolling-release scheme, which means
that any commit is as good as any other; LuaJIT uses the comitter's UNIX
timestamp as its semver patch level. It uses the git-attribute
export-subst for the .relver file that contains the %ct placeholder for
git-archive to expand it.

In c9dcd9e459 (package/luajit: bump to version 41fb94defa8f...), we
switched to such an upstream version. There was some confusion around
the handling of the git-attribute and where/when it is generated, and
the first revision of the patch used the git download method, so had to
use post-extract hooks to do the replacement, but the second iteration
kept retrieving the archive generated by github, which has the
replacement already done, but the post-extract hooks were not dropped
although now useless...

With the current code, it is easy to bump the LuaJit version and forget
to update the timestamp stored in the .relver file, which would override
the value that was generated on the github side.

Since the post-extract hook is useless, drop it.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Francois Perrad <fperrad@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Arnout Vandecappelle <arnout@mind.be>
This commit is contained in:
Yann E. MORIN 2024-05-04 23:40:05 +02:00 committed by Arnout Vandecappelle
parent 4b5e158596
commit 1bcb51517c
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
package/luajit/luajit.mk
View File

@ -33,15 +33,6 @@ LUAJIT_HOST_CC = $(HOSTCC) -m32
LUAJIT_XCFLAGS += -DLUAJIT_DISABLE_GC64 LUAJIT_XCFLAGS += -DLUAJIT_DISABLE_GC64
endif endif
# emulation of git archive with .gitattributes & export-subst
# Timestamp of the $(LUAJIT_VERSION) commit, obtained in the LuaJit
# repo, with: git show -s --format=%ct $(LUAJIT_VERSION)
define LUAJIT_GEN_RELVER_FILE
echo 1693350652 >$(@D)/.relver
endef
LUAJIT_POST_EXTRACT_HOOKS = LUAJIT_GEN_RELVER_FILE
HOST_LUAJIT_POST_EXTRACT_HOOKS = LUAJIT_GEN_RELVER_FILE
# We unfortunately can't use TARGET_CONFIGURE_OPTS, because the luajit # We unfortunately can't use TARGET_CONFIGURE_OPTS, because the luajit
# build system uses non conventional variable names. # build system uses non conventional variable names.
define LUAJIT_BUILD_CMDS define LUAJIT_BUILD_CMDS