From 1bcb51517ccbe79e5c37f211a20d1d02689298e0 Mon Sep 17 00:00:00 2001 From: "Yann E. MORIN" Date: Sat, 4 May 2024 23:40:05 +0200 Subject: [PATCH] package/luajit: drop useless post-extract hook Since version 2.1, LuaJIT follows a rolling-release scheme, which means that any commit is as good as any other; LuaJIT uses the comitter's UNIX timestamp as its semver patch level. It uses the git-attribute export-subst for the .relver file that contains the %ct placeholder for git-archive to expand it. In c9dcd9e459d6 (package/luajit: bump to version 41fb94defa8f...), we switched to such an upstream version. There was some confusion around the handling of the git-attribute and where/when it is generated, and the first revision of the patch used the git download method, so had to use post-extract hooks to do the replacement, but the second iteration kept retrieving the archive generated by github, which has the replacement already done, but the post-extract hooks were not dropped although now useless... With the current code, it is easy to bump the LuaJit version and forget to update the timestamp stored in the .relver file, which would override the value that was generated on the github side. Since the post-extract hook is useless, drop it. Signed-off-by: Yann E. MORIN Cc: Francois Perrad Cc: Thomas Petazzoni Signed-off-by: Arnout Vandecappelle --- package/luajit/luajit.mk | 9 --------- 1 file changed, 9 deletions(-) diff --git a/package/luajit/luajit.mk b/package/luajit/luajit.mk index 06c8993391..693e22630b 100644 --- a/package/luajit/luajit.mk +++ b/package/luajit/luajit.mk @@ -33,15 +33,6 @@ LUAJIT_HOST_CC = $(HOSTCC) -m32 LUAJIT_XCFLAGS += -DLUAJIT_DISABLE_GC64 endif -# emulation of git archive with .gitattributes & export-subst -# Timestamp of the $(LUAJIT_VERSION) commit, obtained in the LuaJit -# repo, with: git show -s --format=%ct $(LUAJIT_VERSION) -define LUAJIT_GEN_RELVER_FILE - echo 1693350652 >$(@D)/.relver -endef -LUAJIT_POST_EXTRACT_HOOKS = LUAJIT_GEN_RELVER_FILE -HOST_LUAJIT_POST_EXTRACT_HOOKS = LUAJIT_GEN_RELVER_FILE - # We unfortunately can't use TARGET_CONFIGURE_OPTS, because the luajit # build system uses non conventional variable names. define LUAJIT_BUILD_CMDS