827da2242c
There are many issues with this package: - The release tarballs from https://github.com/flutter/engine are in no state to compile. They are only for the use of gclient to download a source directory structure suitable to build the Flutter engine! If you download, extract and attempt to run `./tools/gn --no-goma --no-prebuilt-dart-sdk`, you receive the error message: `No such file or directory: 'flutter/flutter/third_party/gn/gn.' But wait! Wasn't the gn binary just called? No, that's a wrapper in the Flutter source tree that formats arguments to call the real gn binary. The real gn is not provided in the tarball but is downloaded via gclient (among many other supporting repositories.) Even worse, the flutter buildsystem depends on the .git dirs being present. (https://github.com/meta-flutter/meta-flutter/issues/271) This dependency means it is not possible to create a reproducible tarball from the downloaded sources, which is why there is no .hash file provided. I have asked the flutter project to release full tarballs suitable for compiling here: https://github.com/flutter/flutter/issues/130734 - Flutter engine includes a patched copy of clang that must be used to compile. Using a Buildroot-build clang results in linking warning and errors. As such, we depend on LLVM_ARCH_SUPPORTS but use the included clang for building. On the plus side, this saves time having to compile clang. - flutter-engine relies on the "PUB_CACHE", that is provided by flutter-sdk, so we need a build dependency, even if no tool from host-flutter-sdk-bin is used to build flutter-engine Tested with: - Debian 11 and 12 - Ubuntu 18.04, 20.04, and 22.04 - Fedora 38 - Per-package directories Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com> [yann.morin.1998@free.fr: - search gclient.py from PATH - indent shell script with 4 spaces - reorganise schell script with prepare/cleanup - tweak comment about weirdness of flutter buildsystem - use suitable-extactor and TAR_OPTIONS - use FLUTTER_SDK_BIN_PUB_CACHE - add dependency to host-futter-sdk-bin (Adam) ] Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
41 lines
1.5 KiB
Diff
41 lines
1.5 KiB
Diff
From ca175ef5bf7f96db57fb5aa562602dc424fab81c Mon Sep 17 00:00:00 2001
|
|
From: Joel Winarske <joel.winarsk@gmail.com>
|
|
Date: Sun, 5 Mar 2023 10:43:02 -0800
|
|
Subject: [PATCH] fix toolchain paths
|
|
|
|
Flutter includes a copy of clang which is required to build. However, by
|
|
default, build/toolchain/custom/BUILD.gn attempts to use several gcc utilities
|
|
such as ar, readelf, nm, and strip. Change these to the proper llvm provided
|
|
utility.
|
|
|
|
Upstream: https://github.com/flutter/flutter/issues/123073
|
|
|
|
Signed-off-by: Joel Winarske <joel.winarsk@gmail.com>
|
|
Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
|
|
---
|
|
build/toolchain/custom/BUILD.gn | 4 +++++------
|
|
1 file changed, 5 insertions(+), 6 deletions(-)
|
|
|
|
diff --git a/build/toolchain/custom/BUILD.gn b/build/toolchain/custom/BUILD.gn
|
|
index 65b1623..8b3f6f8 100644
|
|
--- a/build/toolchain/custom/BUILD.gn
|
|
+++ b/build/toolchain/custom/BUILD.gn
|
|
@@ -12,11 +12,11 @@ toolchain("custom") {
|
|
# these values in our scope.
|
|
cc = "${toolchain_bin}/clang"
|
|
cxx = "${toolchain_bin}/clang++"
|
|
- ar = "${toolchain_bin}/${custom_target_triple}-ar"
|
|
+ ar = "${toolchain_bin}/llvm-ar"
|
|
ld = "${toolchain_bin}/clang++"
|
|
- readelf = "${toolchain_bin}/${custom_target_triple}-readelf"
|
|
- nm = "${toolchain_bin}/${custom_target_triple}-nm"
|
|
- strip = "${toolchain_bin}/${custom_target_triple}-strip"
|
|
+ readelf = "${toolchain_bin}/llvm-readelf"
|
|
+ nm = "${toolchain_bin}/llvm-nm"
|
|
+ strip = "${toolchain_bin}/llvm-strip"
|
|
|
|
target_triple_flags = "--target=${custom_target_triple}"
|
|
sysroot_flags = "--sysroot ${custom_sysroot}"
|
|
--
|
|
2.39.2
|