kumquat-buildroot/package/ntfs-3g/Config.in
Thomas De Schampheleire be084204eb Config.in files: add missing dependencies to toolchain option comments
When a package A depends on config option B and toolchain option C, then
the comment that is given when C is not fulfilled should also depend on B.
For example:

config BR2_PACKAGE_A
	depends on BR2_B
	depends on BR2_LARGEFILE
	depends on BR2_WCHAR

comment "A needs a toolchain w/ largefile, wchar"
	depends on !BR2_LARGEFILE || !BR2_WCHAR

This comment should actually be:

comment "A needs a toolchain w/ largefile, wchar"
	depends on BR2_B
	depends on !BR2_LARGEFILE || !BR2_WCHAR

or if possible (typically when B is a package config option declared in that
same Config.in file):

if BR2_B

comment "A needs a toolchain w/ largefile, wchar"
	depends on !BR2_LARGEFILE || !BR2_WCHAR

[other config options depending on B]

endif

Otherwise, the comment would be visible even though the other dependencies
are not met.

This patch adds such missing dependencies, and changes existing such
dependencies from
  depends on BR2_BASE_DEP && !BR2_TOOLCHAIN_USES_GLIBC
to
  depends on BR2_BASE_DEP
  depends on !BR2_TOOLCHAIN_USES_GLIBC
so that (positive) base dependencies are separate from the (negative)
toolchain dependencies. This strategy makes it easier to write such comments
(because one can simply copy the base dependency from the actual package
config option), but also avoids complex and long boolean expressions.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 (untested)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2013-11-10 23:59:57 +01:00

36 lines
1.0 KiB
Plaintext

config BR2_PACKAGE_NTFS_3G
bool "ntfs-3g"
depends on BR2_LARGEFILE
depends on BR2_USE_WCHAR
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_USE_MMU
help
The NTFS-3G driver is an open source, freely available
read/write NTFS driver for Linux, FreeBSD, Mac OS X, NetBSD,
and Haiku. It provides safe and fast handling of the Windows
XP, Windows Server 2003, Windows 2000 and Windows Vista file
systems. Most POSIX file system operations are supported, with
the exception of full file ownership and access right support.
http://www.ntfs-3g.org/
if BR2_PACKAGE_NTFS_3G
config BR2_PACKAGE_NTFS_3G_ENCRYPTED
bool "encrypted volumes"
select BR2_PACKAGE_GNUTLS
select BR2_PACKAGE_LIBGCRYPT
help
Enable support for NTFS encrypted volumes.
config BR2_PACKAGE_NTFS_3G_NTFSPROGS
bool "ntfsprogs"
help
Install NTFS utilities.
endif
comment "ntfs-3g needs a toolchain w/ largefile, wchar, threads"
depends on BR2_USE_MMU
depends on !(BR2_LARGEFILE && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS)