3f2bdd0701
Some users may provide custom download commands with spaces in their
arguments, like so:
BR2_HG="hg --config foo.bar='some space-separated value'"
However, the way we currently call those commands does not account
for the extra quotes, and each space-separated part of the command is
interpreted as separate arguments.
Fix that by calling 'eval' on the commands.
Because of the eval, we must further quote our own arguments, to avoid
the eval further splitting them in case there are spaces (even though
we do not support paths with spaces, better be clean from the onset to
avoid breakage in the future).
We change all the wrappers to use a wrapper-function, even those with
a single call, so they all look alike.
Note that we do not single-quote some of the variables, like ${verbose}
because it can be empty and we really do not want to generate an
empty-string argument. That's not a problem, as ${verbose} would not
normally contain space-separated values (it could get set to something
like '-q -v' but in that case we'd still want two arguments, so that's
fine).
Reported-by: Thomas De Schampheleire <patrickdepinguin@gmail.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
Reviewed-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Tested-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
38 lines
937 B
Bash
Executable File
38 lines
937 B
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
# We want to catch any unexpected failure, and exit immediately
|
|
set -e
|
|
|
|
# Download helper for cp, to be called from the download wrapper script
|
|
#
|
|
# Call it as:
|
|
# .../cp [-q] OUT_FILE SRC_FILE
|
|
#
|
|
# Environment:
|
|
# LOCALFILES: the cp command to call
|
|
|
|
# 'cp' usually does not print anything on its stdout, whereas the
|
|
# other download backends, even if not verbose, at least print some
|
|
# progress information.
|
|
# Make 'cp' verbose by default, so it behaves a bit like the others.
|
|
verbose=-v
|
|
|
|
while getopts :q OPT; do
|
|
case "${OPT}" in
|
|
q) verbose=;;
|
|
\?) printf "unknown option '%s'\n" "${OPTARG}" >&2; exit 1;;
|
|
esac
|
|
done
|
|
shift $((OPTIND-1))
|
|
|
|
output="${1}"
|
|
source="${2}"
|
|
|
|
# Caller needs to single-quote its arguments to prevent them from
|
|
# being expanded a second time (in case there are spaces in them)
|
|
_localfiles() {
|
|
eval ${LOCALFILES} "${@}"
|
|
}
|
|
|
|
_localfiles ${verbose} "'${source}'" "'${output}'"
|