kumquat-buildroot/package/enlightenment/Config.in
Thomas De Schampheleire be084204eb Config.in files: add missing dependencies to toolchain option comments
When a package A depends on config option B and toolchain option C, then
the comment that is given when C is not fulfilled should also depend on B.
For example:

config BR2_PACKAGE_A
	depends on BR2_B
	depends on BR2_LARGEFILE
	depends on BR2_WCHAR

comment "A needs a toolchain w/ largefile, wchar"
	depends on !BR2_LARGEFILE || !BR2_WCHAR

This comment should actually be:

comment "A needs a toolchain w/ largefile, wchar"
	depends on BR2_B
	depends on !BR2_LARGEFILE || !BR2_WCHAR

or if possible (typically when B is a package config option declared in that
same Config.in file):

if BR2_B

comment "A needs a toolchain w/ largefile, wchar"
	depends on !BR2_LARGEFILE || !BR2_WCHAR

[other config options depending on B]

endif

Otherwise, the comment would be visible even though the other dependencies
are not met.

This patch adds such missing dependencies, and changes existing such
dependencies from
  depends on BR2_BASE_DEP && !BR2_TOOLCHAIN_USES_GLIBC
to
  depends on BR2_BASE_DEP
  depends on !BR2_TOOLCHAIN_USES_GLIBC
so that (positive) base dependencies are separate from the (negative)
toolchain dependencies. This strategy makes it easier to write such comments
(because one can simply copy the base dependency from the actual package
config option), but also avoids complex and long boolean expressions.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 (untested)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2013-11-10 23:59:57 +01:00

43 lines
1.4 KiB
Plaintext

config BR2_PACKAGE_ENLIGHTENMENT
bool "enlightenment"
select BR2_PACKAGE_EFL
select BR2_PACKAGE_LIBECORE
select BR2_PACKAGE_LIBECORE_X
select BR2_PACKAGE_LIBEINA
select BR2_PACKAGE_LIBEET
select BR2_PACKAGE_LIBEVAS
select BR2_PACKAGE_LIBEVAS_JPEG
select BR2_PACKAGE_LIBEVAS_PNG
select BR2_PACKAGE_LIBEVAS_EET
select BR2_PACKAGE_LIBECORE_EVAS
select BR2_PACKAGE_LIBEDJE
select BR2_PACKAGE_LIBEFREET
select BR2_PACKAGE_LIBEDBUS
select BR2_PACKAGE_LIBEIO
select BR2_PACKAGE_XCB_UTIL_KEYSYMS
select BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS
select BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
# libevas-generic-loaders-svg -> librsvg -> glib2 / pango
depends on BR2_USE_WCHAR
depends on BR2_INSTALL_LIBSTDCPP
# libedbus -> dbus
# libedbus -> glib2
depends on BR2_TOOLCHAIN_HAS_THREADS
# libedbus -> dbus
depends on BR2_USE_MMU
depends on BR2_PACKAGE_XORG7
depends on !BR2_avr32 # libevas
help
Enlightenment, also known simply as E, is a stacking window
manager for the X Window System which can be used alone or
in conjunction with a desktop environment such as GNOME or
KDE. Enlightenment can be used as a substitute for a full
desktop environment.
http://www.enlightenment.org/
comment "enlightenment needs a toolchain w/ wchar, C++, threads"
depends on BR2_PACKAGE_XORG7 && BR2_USE_MMU
depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
depends on !BR2_avr32