be084204eb
When a package A depends on config option B and toolchain option C, then the comment that is given when C is not fulfilled should also depend on B. For example: config BR2_PACKAGE_A depends on BR2_B depends on BR2_LARGEFILE depends on BR2_WCHAR comment "A needs a toolchain w/ largefile, wchar" depends on !BR2_LARGEFILE || !BR2_WCHAR This comment should actually be: comment "A needs a toolchain w/ largefile, wchar" depends on BR2_B depends on !BR2_LARGEFILE || !BR2_WCHAR or if possible (typically when B is a package config option declared in that same Config.in file): if BR2_B comment "A needs a toolchain w/ largefile, wchar" depends on !BR2_LARGEFILE || !BR2_WCHAR [other config options depending on B] endif Otherwise, the comment would be visible even though the other dependencies are not met. This patch adds such missing dependencies, and changes existing such dependencies from depends on BR2_BASE_DEP && !BR2_TOOLCHAIN_USES_GLIBC to depends on BR2_BASE_DEP depends on !BR2_TOOLCHAIN_USES_GLIBC so that (positive) base dependencies are separate from the (negative) toolchain dependencies. This strategy makes it easier to write such comments (because one can simply copy the base dependency from the actual package config option), but also avoids complex and long boolean expressions. Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> (untested) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
42 lines
1.1 KiB
Plaintext
42 lines
1.1 KiB
Plaintext
config BR2_PACKAGE_UDISKS
|
|
bool "udisks"
|
|
depends on BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
|
|
depends on BR2_TOOLCHAIN_HAS_THREADS # dbus-glib -> glib2
|
|
depends on BR2_USE_MMU # lvm2
|
|
select BR2_PACKAGE_UDEV
|
|
select BR2_PACKAGE_UDEV_ALL_EXTRAS
|
|
select BR2_PACKAGE_DBUS
|
|
select BR2_PACKAGE_DBUS_GLIB
|
|
depends on BR2_USE_WCHAR # dbus-glib -> glib2
|
|
select BR2_PACKAGE_SG3_UTILS
|
|
select BR2_PACKAGE_POLKIT
|
|
select BR2_PACKAGE_PARTED
|
|
select BR2_PACKAGE_LVM2
|
|
select BR2_PACKAGE_LIBATASMART
|
|
help
|
|
The udisks project provides
|
|
|
|
o A storage daemon that implements well-defined D-Bus
|
|
interfaces that can be used to query and manipulate
|
|
storage devices.
|
|
|
|
o a command-line tool, udisks(1), that can be used to query
|
|
and use the daemon
|
|
|
|
http://www.freedesktop.org/wiki/Software/udisks
|
|
|
|
if BR2_PACKAGE_UDISKS
|
|
|
|
config BR2_PACKAGE_UDISKS_LVM2
|
|
bool "lvm2 support"
|
|
select BR2_PACKAGE_LVM2_APP_LIBRARY
|
|
help
|
|
Enable LVM2 support
|
|
|
|
endif
|
|
|
|
comment "udisks needs udev /dev management and a toolchain w/ wchar, threads"
|
|
depends on BR2_USE_MMU
|
|
depends on !BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV || \
|
|
!BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
|