kumquat-buildroot/package/nfs-utils/Config.in
Thomas De Schampheleire be084204eb Config.in files: add missing dependencies to toolchain option comments
When a package A depends on config option B and toolchain option C, then
the comment that is given when C is not fulfilled should also depend on B.
For example:

config BR2_PACKAGE_A
	depends on BR2_B
	depends on BR2_LARGEFILE
	depends on BR2_WCHAR

comment "A needs a toolchain w/ largefile, wchar"
	depends on !BR2_LARGEFILE || !BR2_WCHAR

This comment should actually be:

comment "A needs a toolchain w/ largefile, wchar"
	depends on BR2_B
	depends on !BR2_LARGEFILE || !BR2_WCHAR

or if possible (typically when B is a package config option declared in that
same Config.in file):

if BR2_B

comment "A needs a toolchain w/ largefile, wchar"
	depends on !BR2_LARGEFILE || !BR2_WCHAR

[other config options depending on B]

endif

Otherwise, the comment would be visible even though the other dependencies
are not met.

This patch adds such missing dependencies, and changes existing such
dependencies from
  depends on BR2_BASE_DEP && !BR2_TOOLCHAIN_USES_GLIBC
to
  depends on BR2_BASE_DEP
  depends on !BR2_TOOLCHAIN_USES_GLIBC
so that (positive) base dependencies are separate from the (negative)
toolchain dependencies. This strategy makes it easier to write such comments
(because one can simply copy the base dependency from the actual package
config option), but also avoids complex and long boolean expressions.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 (untested)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2013-11-10 23:59:57 +01:00

41 lines
1.1 KiB
Plaintext

config BR2_PACKAGE_NFS_UTILS
bool "nfs-utils"
depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC || BR2_TOOLCHAIN_HAS_THREADS # libtirpc
select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
depends on BR2_LARGEFILE
depends on BR2_USE_MMU # fork()
help
The NFS Linux kernel server.
Warning: We do not force largefile support on here on purpose.
Enable it yourself if you want to access big exports!
http://sourceforge.net/projects/nfs
comment "nfs-utils needs a toolchain w/ largefile, threads"
depends on BR2_USE_MMU
depends on !BR2_LARGEFILE || \
!(BR2_TOOLCHAIN_HAS_THREADS || BR2_TOOLCHAIN_HAS_NATIVE_RPC)
menu "NFS utilities selection"
depends on BR2_PACKAGE_NFS_UTILS
config BR2_PACKAGE_NFS_UTILS_RPCDEBUG
bool "rpcdebug"
depends on BR2_PACKAGE_NFS_UTILS
help
The RPC debugging utility
config BR2_PACKAGE_NFS_UTILS_RPC_LOCKD
bool "rpc.lockd"
depends on BR2_PACKAGE_NFS_UTILS
help
NFS lock manager for Linux kernels older than 2.4
config BR2_PACKAGE_NFS_UTILS_RPC_RQUOTAD
bool "rpc.rquotad"
depends on BR2_PACKAGE_NFS_UTILS
help
NFS remote quota server
endmenu