be084204eb
When a package A depends on config option B and toolchain option C, then the comment that is given when C is not fulfilled should also depend on B. For example: config BR2_PACKAGE_A depends on BR2_B depends on BR2_LARGEFILE depends on BR2_WCHAR comment "A needs a toolchain w/ largefile, wchar" depends on !BR2_LARGEFILE || !BR2_WCHAR This comment should actually be: comment "A needs a toolchain w/ largefile, wchar" depends on BR2_B depends on !BR2_LARGEFILE || !BR2_WCHAR or if possible (typically when B is a package config option declared in that same Config.in file): if BR2_B comment "A needs a toolchain w/ largefile, wchar" depends on !BR2_LARGEFILE || !BR2_WCHAR [other config options depending on B] endif Otherwise, the comment would be visible even though the other dependencies are not met. This patch adds such missing dependencies, and changes existing such dependencies from depends on BR2_BASE_DEP && !BR2_TOOLCHAIN_USES_GLIBC to depends on BR2_BASE_DEP depends on !BR2_TOOLCHAIN_USES_GLIBC so that (positive) base dependencies are separate from the (negative) toolchain dependencies. This strategy makes it easier to write such comments (because one can simply copy the base dependency from the actual package config option), but also avoids complex and long boolean expressions. Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> (untested) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
30 lines
1.1 KiB
Plaintext
30 lines
1.1 KiB
Plaintext
comment "ltp-testsuite needs specific uClibc options, see help"
|
|
depends on BR2_PACKAGE_LTP_TESTSUITE
|
|
depends on BR2_TOOLCHAIN_USES_UCLIBC
|
|
|
|
config BR2_PACKAGE_LTP_TESTSUITE
|
|
bool "ltp-testsuite"
|
|
depends on BR2_TOOLCHAIN_HAS_THREADS
|
|
depends on BR2_INET_IPV6
|
|
depends on BR2_LARGEFILE
|
|
depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC
|
|
# aarch64 build currently broken, reported at
|
|
# https://bugs.launchpad.net/linaro-aarch64/+bug/1236027
|
|
depends on !BR2_aarch64
|
|
help
|
|
The Linux Test Project provides a huge testsuite for Linux.
|
|
|
|
The LTP testsuite uses several functions that are considered
|
|
obsolete, such as sigset() and others. Therefore, the LTP
|
|
testsuite does not build with Buildroot's default uClibc
|
|
configuration, and options such as DO_XSI_MATH,
|
|
UCLIBC_HAS_OBSOLETE_BSD_SIGNAL and UCLIBC_SV4_DEPRECATED
|
|
are needed.
|
|
|
|
http://ltp.sourceforge.net/
|
|
|
|
comment "ltp-testsuite needs a toolchain w/ IPv6, RPC, largefile, threads"
|
|
depends on !BR2_aarch64
|
|
depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INET_IPV6 || \
|
|
!BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_NATIVE_RPC
|