c5a3dfb9a4
Currently only SysV init scripts are checked using shellcheck and a few other rules (e.g. variable naming, file naming). Extend the check using shellcheck to all shell scripts in the tree. This is actually limited to the list of directories that check-package knows that can check, but that list can be expanded later. In order to apply the check to all shell scripts, use python3-magic to determine the file type. Unfortunately, there are two different python modules called "magic". Support both by detecting which one is installed and defining get_filetype accordingly. Keep testing first for name pattern, and only in the case there is no match, check the file type. This ensures, for instance, that SysV init scripts follow specific rules. Apply these checks for shell scripts: - shellcheck; - trailing space; - consecutive empty lines; - empty last line on file; - newline at end of file. Update the list of ignored warnings. Do not add unit tests since no function was added, they were just reused. But expand the runtime test for check-package using as fixture a file that generates a shellcheck warning. Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> [Arnout: support both variants of the "magic" module] Signed-off-by: Arnout Vandecappelle <arnout@mind.be> |
||
---|---|---|
.. | ||
checkpackagelib | ||
checksymbolslib | ||
brmake | ||
check-package | ||
check-symbols | ||
config | ||
diffconfig | ||
docker-run | ||
genrandconfig | ||
get-developers | ||
getdeveloperlib.py | ||
readme.txt | ||
scancpan | ||
scanpypi | ||
size-stats-compare | ||
test-pkg |
This directory contains various useful scripts and tools for working with Buildroot. You need not add this directory in your PATH to use any of those tools, but you may do so if you want. brmake a script that can be run instead of make, that prepends the date in front of each line, redirects all of the build output to a file ("'br.log' in the current directory), and just outputs the Buildroot messages (those lines starting with >>>) on stdout. Do not run this script for interactive configuration (e.g. menuconfig) or on an unconfigured directory. The output is redirected so you will see nothing. check-package a script that checks the coding style of a package's Config.in and .mk files, and also tests them for various types of typoes. genrandconfig a script that generates a random configuration, used by the autobuilders (http://autobuild.buildroot.org). It selects a random toolchain from support/config-fragments/autobuild and randomly selects packages to build. get-developers a script to return the list of people interested in a specific part of Buildroot, so they can be Cc:ed on a mail. Accepts a patch as input, a package name or and architecture name. scancpan a script to create a Buildroot package by scanning a CPAN module description. scanpypi a script to create a Buildroot package by scanning a PyPI package description. size-stats-compare a script to compare the rootfs size between two different Buildroot configurations. This can be used to identify the size impact of a specific option, of a set of specific options, or of an update to a newer Buildroot version... test-pkg a script that tests a specific package against a set of various toolchains, with the goal to detect toolchain-related dependencies (wchar, threads...)