kumquat-buildroot/package/targetcli-fb/targetcli-fb.mk
Yann E. MORIN c19cca0452 package: switch to _CPE_ID_VALID
Now that we document _CPE_ID_VALID, and that it shall be used instead of
setting a default value to one of the other _CPE_ID_* variables, change
all of the existing packages to use it, to avoid any error when we later
extend check-package to validate the sanity ofthe _CPE_ID_* variables.

Mechanical change done within the reference container, running the new
check in check-package, to report the CPE_ID errors:

    $ make check-package 2>/dev/null \
    |awk '{
            split($(1), a, ":"); fname = a[1]
            split($(2), a, "'\''"); val = a[2]
            new_var = $(8); gsub("_CPE_ID_.*", "_CPE_ID_VALID", new_var)
            printf("%s %s %s %s\n", fname, $(8), val, new_var)
    }' \
    |while read fname var val new_var; do
        sed -r -i -e "s/${var}[[:space:]]*=[[:space:]]*${val}/${new_var} = YES/" "${fname}"
    done

    $ git diff -I'CPE_ID_(VENDOR|VALID)'
    [empty]

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
2024-02-11 16:30:06 +01:00

36 lines
1.2 KiB
Makefile

################################################################################
#
# targetcli-fb
#
################################################################################
# When upgrading the version, be sure to also upgrade python-rtslib-fb
# and python-configshell-fb at the same time.
TARGETCLI_FB_VERSION = 2.1.54
TARGETCLI_FB_SITE = $(call github,open-iscsi,targetcli-fb,v$(TARGETCLI_FB_VERSION))
TARGETCLI_FB_LICENSE = Apache-2.0
TARGETCLI_FB_LICENSE_FILES = COPYING
TARGETCLI_FB_CPE_ID_VALID = YES
TARGETCLI_FB_SETUP_TYPE = setuptools
TARGETCLI_FB_DEPENDENCIES = python-configshell-fb python-rtslib-fb python-six
define TARGETCLI_FB_INSTALL_INIT_SYSV
$(INSTALL) -m 0755 -D package/targetcli-fb/S50target \
$(TARGET_DIR)/etc/init.d/S50target
endef
define TARGETCLI_FB_INSTALL_INIT_SYSTEMD
$(INSTALL) -m 0644 -D package/targetcli-fb/target.service \
$(TARGET_DIR)/usr/lib/systemd/system/target.service
endef
# Targetcli stores its configuration in /etc/target/saveconfig.json
# and complains if the /etc/target/ directory does not exist.
define TARGETCLI_FB_INSTALL_CONF_DIR
$(INSTALL) -m 0755 -d $(TARGET_DIR)/etc/target
endef
TARGETCLI_FB_POST_INSTALL_TARGET_HOOKS += TARGETCLI_FB_INSTALL_CONF_DIR
$(eval $(python-package))