19afad50f5
DL_DIR can be a very precious place for some users: they use it to store
all the downloaded archives to share across all their Buildroot (and
maybe non-Buildroot) builds.
We do not want to trash this location with our temporary downloads (e.g.
git, Hg, svn, cvs repository clones/checkouts, or wget, bzr tep tarballs).
Turns out that we already have some kind of scratchpad, the BUILD_DIR.
Although it is not really a disposable location, that's the best we have
so far.
Also, we create the temporary tarballs with mktemp using the final tarball,
as template, since we want the temporary to be on the same filesystem as
the final location, so the 'mv' is just a plain, atomic rename(2), and we
are not left with a half-copied file as the final location.
Using mktemp ensures all temp file names are unique, so it allows for
parallel downloads from different build dirs at the same time, without
cloberring each downloads.
Note: we're using neither ${TMP} nor ${TMPDIR} since they are shared
locations, sometime with little place (eg. tmpfs), and some of the
repositories we clone/checkout can be very big.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Samuel Martin <s.martin49@gmail.com>
Cc: Arnout Vandecappelle <arnout@mind.be>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
Tested-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
[tested a particular scenario that used to fail: two separate builds
using a shared DL_DIR, ccache enabled, so that they run almost
synchronously. These would download the same file at the same time,
corrupting each other. With the patches in this series, all works
fine.]
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
36 lines
851 B
Bash
Executable File
36 lines
851 B
Bash
Executable File
#!/bin/bash
|
|
|
|
# We want to catch any command failure, and exit immediately
|
|
set -e
|
|
|
|
# Download helper for wget
|
|
# Call it with:
|
|
# $1: URL
|
|
# $2: output file
|
|
# And this environment:
|
|
# WGET : the wget command to call
|
|
# BUILD_DIR: path to Buildroot's build dir
|
|
|
|
url="${1}"
|
|
output="${2}"
|
|
|
|
tmp_dl="$( mktemp "${BUILD_DIR}/.XXXXXX" )"
|
|
tmp_output="$( mktemp "${output}.XXXXXX" )"
|
|
|
|
# Play tic-tac-toe with temp files
|
|
# - first, we download to a trashable location (the build-dir)
|
|
# - then we copy to a temporary tarball in the final location, so it is
|
|
# on the same filesystem as the final file
|
|
# - finally, we atomically rename to the final file
|
|
|
|
ret=1
|
|
if ${WGET} -O "${tmp_dl}" "${url}"; then
|
|
if mv "${tmp_dl}" "${tmp_output}"; then
|
|
mv "${tmp_output}" "${output}"
|
|
ret=0
|
|
fi
|
|
fi
|
|
|
|
rm -f "${tmp_dl}" "${tmp_output}"
|
|
exit ${ret}
|