be084204eb
When a package A depends on config option B and toolchain option C, then the comment that is given when C is not fulfilled should also depend on B. For example: config BR2_PACKAGE_A depends on BR2_B depends on BR2_LARGEFILE depends on BR2_WCHAR comment "A needs a toolchain w/ largefile, wchar" depends on !BR2_LARGEFILE || !BR2_WCHAR This comment should actually be: comment "A needs a toolchain w/ largefile, wchar" depends on BR2_B depends on !BR2_LARGEFILE || !BR2_WCHAR or if possible (typically when B is a package config option declared in that same Config.in file): if BR2_B comment "A needs a toolchain w/ largefile, wchar" depends on !BR2_LARGEFILE || !BR2_WCHAR [other config options depending on B] endif Otherwise, the comment would be visible even though the other dependencies are not met. This patch adds such missing dependencies, and changes existing such dependencies from depends on BR2_BASE_DEP && !BR2_TOOLCHAIN_USES_GLIBC to depends on BR2_BASE_DEP depends on !BR2_TOOLCHAIN_USES_GLIBC so that (positive) base dependencies are separate from the (negative) toolchain dependencies. This strategy makes it easier to write such comments (because one can simply copy the base dependency from the actual package config option), but also avoids complex and long boolean expressions. Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> (untested) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
46 lines
1.2 KiB
Plaintext
46 lines
1.2 KiB
Plaintext
config BR2_PACKAGE_LIBEDBUS
|
|
bool "libedbus"
|
|
select BR2_PACKAGE_LIBEINA
|
|
select BR2_PACKAGE_LIBECORE
|
|
select BR2_PACKAGE_DBUS
|
|
depends on BR2_TOOLCHAIN_HAS_THREADS # dbus
|
|
depends on BR2_USE_MMU # dbus
|
|
help
|
|
E_Dbus is a set of wrappers around D-Bus APIs so they can be
|
|
easily used by EFL applications, automatically providing
|
|
Ecore/main loop integration, as well as Eina data types.
|
|
|
|
http://trac.enlightenment.org/e/wiki/E_Dbus
|
|
|
|
if BR2_PACKAGE_LIBEDBUS
|
|
|
|
config BR2_PACKAGE_LIBEDBUS_BLUEZ
|
|
bool "bluez support"
|
|
depends on !BR2_avr32 # bluez_utils
|
|
depends on BR2_USE_WCHAR # bluez_utils -> glib2
|
|
depends on BR2_TOOLCHAIN_HAS_THREADS # bluez_utils -> glib2
|
|
select BR2_PACKAGE_BLUEZ_UTILS
|
|
help
|
|
Bluetooth support.
|
|
|
|
comment "bluez support needs a toolchain w/ wchar, threads"
|
|
depends on !BR2_avr32
|
|
depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
|
|
|
|
config BR2_PACKAGE_LIBEDBUS_CONNMAN
|
|
bool "connman support"
|
|
depends on BR2_PACKAGE_CONNMAN
|
|
help
|
|
Connection manager support.
|
|
|
|
config BR2_PACKAGE_LIBEDBUS_NOTIFY
|
|
bool "notify support"
|
|
help
|
|
Notify support.
|
|
|
|
endif
|
|
|
|
comment "libedbus needs a toolchain w/ threads"
|
|
depends on BR2_USE_MMU
|
|
depends on !BR2_TOOLCHAIN_HAS_THREADS
|