be084204eb
When a package A depends on config option B and toolchain option C, then the comment that is given when C is not fulfilled should also depend on B. For example: config BR2_PACKAGE_A depends on BR2_B depends on BR2_LARGEFILE depends on BR2_WCHAR comment "A needs a toolchain w/ largefile, wchar" depends on !BR2_LARGEFILE || !BR2_WCHAR This comment should actually be: comment "A needs a toolchain w/ largefile, wchar" depends on BR2_B depends on !BR2_LARGEFILE || !BR2_WCHAR or if possible (typically when B is a package config option declared in that same Config.in file): if BR2_B comment "A needs a toolchain w/ largefile, wchar" depends on !BR2_LARGEFILE || !BR2_WCHAR [other config options depending on B] endif Otherwise, the comment would be visible even though the other dependencies are not met. This patch adds such missing dependencies, and changes existing such dependencies from depends on BR2_BASE_DEP && !BR2_TOOLCHAIN_USES_GLIBC to depends on BR2_BASE_DEP depends on !BR2_TOOLCHAIN_USES_GLIBC so that (positive) base dependencies are separate from the (negative) toolchain dependencies. This strategy makes it easier to write such comments (because one can simply copy the base dependency from the actual package config option), but also avoids complex and long boolean expressions. Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> (untested) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
33 lines
1.2 KiB
Plaintext
33 lines
1.2 KiB
Plaintext
config BR2_PACKAGE_LTTNG_BABELTRACE
|
|
bool "lttng-babeltrace"
|
|
depends on BR2_PACKAGE_LTTNG_TOOLS
|
|
select BR2_PACKAGE_UTIL_LINUX
|
|
select BR2_PACKAGE_UTIL_LINUX_LIBUUID
|
|
select BR2_PACKAGE_LIBGLIB2
|
|
# libglib2 needs thread support and gettext which needs wchar support, and
|
|
# we also depends on util-linux which needs wchar
|
|
depends on BR2_USE_WCHAR
|
|
depends on BR2_TOOLCHAIN_HAS_THREADS
|
|
# util-linux depends on largefile support
|
|
depends on BR2_LARGEFILE
|
|
help
|
|
Babeltrace is part of the LTTng 2.x project.
|
|
|
|
This project provides trace read and write libraries, as
|
|
well as a trace converter. A plugin can be created for any
|
|
trace format to allow its conversion to/from another trace
|
|
format.
|
|
|
|
Having this tool on the target is not mandatory. You can
|
|
transfer the binary trace output from the target to your
|
|
development workstation, and use babeltrace here. Buildroot
|
|
automatically builds a host babeltrace in
|
|
$(O)/host/usr/bin/babeltrace as a dependency of the
|
|
lttng-tools package.
|
|
|
|
http://lttng.org
|
|
|
|
comment "lttng-babeltrace needs a toolchain w/ wchar, threads, largefile"
|
|
depends on BR2_PACKAGE_LTTNG_TOOLS
|
|
depends on !BR2_USE_WCHAR || !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
|