eb4f5a2cbc
OpenBLAS Makefile normally needs to explicitly define the CPU
architecture size (32 or 64bit) in the BINARY macro. See [1].
When an architecture supports both 64 and 32bit, the 32bit support
is sometimes implemented in OpenBLAS by overriding a fallback to an
anterior architecture. For example, if the build target architecture
is x86 Haswell 32bit, OpenBLAS build will override the arch to
Nehalem. See [2].
If the BINARY macro is undefined, the 32bit fallback will not happen,
sometimes leading to a link failure, with output:
i686-buildroot-linux-gnu/bin/ar: strmm_kernel_LN.o: No such file or directory
This commit fixes those issues by explicitly defining the BINARY
macro. This issue has also been discussed upstream in [3] and [4].
Note: this issue was not introduced recently ([3] dates back from 2015),
and was also see in previous package version, for example in [5].
Fixes:
http://autobuild.buildroot.net/results/e1e/e1e2034a78799abe1bd28b036fa6f7d13322e42f
[1] https://github.com/xianyi/OpenBLAS/blob/v0.3.24/Makefile.rule#L50
[2] https://github.com/xianyi/OpenBLAS/blob/v0.3.24/Makefile.system#L113
[3] https://github.com/xianyi/OpenBLAS/issues/657
[4] https://github.com/xianyi/OpenBLAS/issues/1106
[5] http://autobuild.buildroot.net/results/5cd/5cdccd106b1de275ac75c39783e536107a31651f
Signed-off-by: Julien Olivain <ju.o@free.fr>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
106 lines
3.2 KiB
Makefile
106 lines
3.2 KiB
Makefile
################################################################################
|
|
#
|
|
# openblas
|
|
#
|
|
################################################################################
|
|
|
|
OPENBLAS_VERSION = 0.3.24
|
|
OPENBLAS_SITE = https://github.com/xianyi/OpenBLAS/releases/download/v$(OPENBLAS_VERSION)
|
|
OPENBLAS_LICENSE = BSD-3-Clause
|
|
OPENBLAS_LICENSE_FILES = LICENSE
|
|
OPENBLAS_INSTALL_STAGING = YES
|
|
OPENBLAS_CPE_ID_VENDOR = openblas_project
|
|
|
|
# Initialise OpenBLAS make options to $(TARGET_CONFIGURE_OPTS)
|
|
OPENBLAS_MAKE_OPTS = $(TARGET_CONFIGURE_OPTS)
|
|
|
|
# Enable cross-compiling
|
|
OPENBLAS_MAKE_OPTS += CROSS=1
|
|
|
|
# Set OpenBLAS target
|
|
OPENBLAS_MAKE_OPTS += TARGET=$(BR2_PACKAGE_OPENBLAS_TARGET)
|
|
|
|
# When Fortran is not available, only build the C version of BLAS
|
|
ifeq ($(BR2_TOOLCHAIN_HAS_FORTRAN),)
|
|
OPENBLAS_MAKE_OPTS += ONLY_CBLAS=1
|
|
endif
|
|
|
|
# Enable/Disable multi-threading (not for static-only since it uses dlfcn.h)
|
|
ifeq ($(BR2_PACKAGE_OPENBLAS_USE_THREAD),y)
|
|
OPENBLAS_MAKE_OPTS += USE_THREAD=1
|
|
else
|
|
OPENBLAS_MAKE_OPTS += USE_THREAD=0
|
|
endif
|
|
|
|
ifeq ($(BR2_PACKAGE_OPENBLAS_USE_LOCKING),y)
|
|
OPENBLAS_MAKE_OPTS += USE_LOCKING=1
|
|
else
|
|
# not passing USE_LOCKING=0 as this could be confusing: its effect is implicit
|
|
# in case of USE_THREAD=1.
|
|
endif
|
|
|
|
# We don't know if OpenMP is available or not, so disable
|
|
OPENBLAS_MAKE_OPTS += USE_OPENMP=0
|
|
|
|
# Static-only/Shared-only toggle
|
|
# Note: static library is always generated so that applications can link
|
|
# statically for size reduction, even if BR2_STATIC_LIBS is not set.
|
|
ifeq ($(BR2_STATIC_LIBS),y)
|
|
OPENBLAS_MAKE_OPTS += NO_SHARED=1
|
|
endif
|
|
|
|
ifeq ($(BR2_ARCH_IS_64),y)
|
|
OPENBLAS_MAKE_OPTS += BINARY=64
|
|
else
|
|
OPENBLAS_MAKE_OPTS += BINARY=32
|
|
endif
|
|
|
|
# binutils version <= 2.23.2 has a bug
|
|
# (https://sourceware.org/bugzilla/show_bug.cgi?id=14887) where
|
|
# whitespaces in ARM register specifications such as [ r1, #12 ] or [
|
|
# r2 ] cause the assembler to reject the code. Since there are
|
|
# numerous instances of such cases in the code, we use sed rather than
|
|
# a patch. We simply replace [ foobar ] by [foobar] to work around the
|
|
# problem.
|
|
define OPENBLAS_FIXUP_ARM_ASSEMBLY
|
|
$(SED) 's%\[\s*%\[%;s%\s*\]%\]%' $(@D)/kernel/arm/*.S
|
|
endef
|
|
|
|
OPENBLAS_POST_PATCH_HOOKS += OPENBLAS_FIXUP_ARM_ASSEMBLY
|
|
|
|
define OPENBLAS_BUILD_CMDS
|
|
$(TARGET_MAKE_ENV) $(MAKE) $(OPENBLAS_MAKE_OPTS) \
|
|
-C $(@D)
|
|
endef
|
|
|
|
define OPENBLAS_INSTALL_STAGING_CMDS
|
|
$(TARGET_MAKE_ENV) $(MAKE) $(OPENBLAS_MAKE_OPTS) \
|
|
-C $(@D) install PREFIX=$(STAGING_DIR)/usr
|
|
endef
|
|
|
|
define OPENBLAS_INSTALL_TARGET_CMDS
|
|
$(TARGET_MAKE_ENV) $(MAKE) $(OPENBLAS_MAKE_OPTS) \
|
|
-C $(@D) install PREFIX=$(TARGET_DIR)/usr
|
|
endef
|
|
|
|
ifeq ($(BR2_PACKAGE_OPENBLAS_INSTALL_TESTS),y)
|
|
# Tests are always built, but are not installed, so we need to install
|
|
# them manually. The set of available tests may fluctuate depending on
|
|
# the architecture and other options, so only install whatever gets
|
|
# built.
|
|
define OPENBLAS_INSTALL_TESTS
|
|
mkdir -p $(TARGET_DIR)/usr/libexec/openblas/tests
|
|
find $(@D)/ctest \
|
|
-type f -name "x[sdcz]cblat[123]" -perm -0100 \
|
|
-exec $(INSTALL) -m 0755 {} \
|
|
$(TARGET_DIR)/usr/libexec/openblas/tests \;
|
|
find $(@D)/ctest \
|
|
-type f -name "[sdcz]in[123]" \
|
|
-exec $(INSTALL) -m 0644 {} \
|
|
$(TARGET_DIR)/usr/libexec/openblas/tests \;
|
|
endef
|
|
OPENBLAS_POST_INSTALL_TARGET_HOOKS += OPENBLAS_INSTALL_TESTS
|
|
endif
|
|
|
|
$(eval $(generic-package))
|