kumquat-buildroot/package/connman/Config.in
Thomas De Schampheleire be084204eb Config.in files: add missing dependencies to toolchain option comments
When a package A depends on config option B and toolchain option C, then
the comment that is given when C is not fulfilled should also depend on B.
For example:

config BR2_PACKAGE_A
	depends on BR2_B
	depends on BR2_LARGEFILE
	depends on BR2_WCHAR

comment "A needs a toolchain w/ largefile, wchar"
	depends on !BR2_LARGEFILE || !BR2_WCHAR

This comment should actually be:

comment "A needs a toolchain w/ largefile, wchar"
	depends on BR2_B
	depends on !BR2_LARGEFILE || !BR2_WCHAR

or if possible (typically when B is a package config option declared in that
same Config.in file):

if BR2_B

comment "A needs a toolchain w/ largefile, wchar"
	depends on !BR2_LARGEFILE || !BR2_WCHAR

[other config options depending on B]

endif

Otherwise, the comment would be visible even though the other dependencies
are not met.

This patch adds such missing dependencies, and changes existing such
dependencies from
  depends on BR2_BASE_DEP && !BR2_TOOLCHAIN_USES_GLIBC
to
  depends on BR2_BASE_DEP
  depends on !BR2_TOOLCHAIN_USES_GLIBC
so that (positive) base dependencies are separate from the (negative)
toolchain dependencies. This strategy makes it easier to write such comments
(because one can simply copy the base dependency from the actual package
config option), but also avoids complex and long boolean expressions.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 (untested)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2013-11-10 23:59:57 +01:00

57 lines
1.5 KiB
Plaintext

config BR2_PACKAGE_CONNMAN
bool "connman"
select BR2_PACKAGE_DBUS
select BR2_PACKAGE_LIBGLIB2
select BR2_PACKAGE_IPTABLES
select BR2_PACKAGE_GNUTLS
depends on !BR2_avr32 # no inotify_init1
depends on !BR2_UCLIBC_VERSION_0_9_32
depends on BR2_USE_WCHAR # libglib2 and gnutls
depends on BR2_INET_IPV6
depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
depends on BR2_USE_MMU # dbus
help
The Connection Manager (ConnMan) project provides a daemon for
managing internet connections within embedded devices running
the Linux operating system.
For more information, see http://connman.net/
if BR2_PACKAGE_CONNMAN
config BR2_PACKAGE_CONNMAN_THREADS
bool "enable threading support"
depends on BR2_TOOLCHAIN_HAS_THREADS
default y
config BR2_PACKAGE_CONNMAN_ETHERNET
bool "enable Ethernet support"
default y
config BR2_PACKAGE_CONNMAN_WIFI
bool "enable WiFi support"
select BR2_PACKAGE_WPA_SUPPLICANT
config BR2_PACKAGE_CONNMAN_BLUETOOTH
bool "enable Bluetooth support"
config BR2_PACKAGE_CONNMAN_LOOPBACK
bool "enable loopback support"
config BR2_PACKAGE_CONNMAN_NTPD
bool "enable ntpd support"
config BR2_PACKAGE_CONNMAN_DEBUG
bool "enable compiling with debugging information"
config BR2_PACKAGE_CONNMAN_CLIENT
bool "enable command line client"
select BR2_PACKAGE_READLINE
endif # BR2_PACKAGE_CONNMAN
comment "connman needs a toolchain w/ IPv6, wchar, threads, resolver"
depends on BR2_USE_MMU && !BR2_avr32
depends on BR2_UCLIBC_VERSION_0_9_32 || \
!BR2_USE_WCHAR || !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADS