2f7a8021b5
Details: https://lists.gnu.org/archive/html/grub-devel/2020-07/msg00034.html Fixes the following security issues: * CVE-2020-10713 A flaw was found in grub2, prior to version 2.06. An attacker may use the GRUB 2 flaw to hijack and tamper the GRUB verification process. This flaw also allows the bypass of Secure Boot protections. In order to load an untrusted or modified kernel, an attacker would first need to establish access to the system such as gaining physical access, obtain the ability to alter a pxe-boot network, or have remote access to a networked system with root access. With this access, an attacker could then craft a string to cause a buffer overflow by injecting a malicious payload that leads to arbitrary code execution within GRUB. The highest threat from this vulnerability is to data confidentiality and integrity as well as system availability. * CVE-2020-14308 In grub2 versions before 2.06 the grub memory allocator doesn't check for possible arithmetic overflows on the requested allocation size. This leads the function to return invalid memory allocations which can be further used to cause possible integrity, confidentiality and availability impacts during the boot process. * CVE-2020-14309 There's an issue with grub2 in all versions before 2.06 when handling squashfs filesystems containing a symbolic link with name length of UINT32 bytes in size. The name size leads to an arithmetic overflow leading to a zero-size allocation further causing a heap-based buffer overflow with attacker controlled data. * CVE-2020-14310 An integer overflow in read_section_from_string may lead to a heap based buffer overflow. * CVE-2020-14311 An integer overflow in grub_ext2_read_link may lead to a heap-based buffer overflow. * CVE-2020-15706 GRUB2 contains a race condition in grub_script_function_create() leading to a use-after-free vulnerability which can be triggered by redefining a function whilst the same function is already executing, leading to arbitrary code execution and secure boot restriction bypass * CVE-2020-15707 Integer overflows were discovered in the functions grub_cmd_initrd and grub_initrd_init in the efilinux component of GRUB2, as shipped in Debian, Red Hat, and Ubuntu (the functionality is not included in GRUB2 upstream), leading to a heap-based buffer overflow. These could be triggered by an extremely large number of arguments to the initrd command on 32-bit architectures, or a crafted filesystem with very large files on any architecture. An attacker could use this to execute arbitrary code and bypass UEFI Secure Boot restrictions. This issue affects GRUB2 version 2.04 and prior versions. Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
70 lines
2.5 KiB
Diff
70 lines
2.5 KiB
Diff
From 8d3b6f9da468f666e3a7976657f2ab5c52762a21 Mon Sep 17 00:00:00 2001
|
|
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
|
|
Date: Tue, 7 Jul 2020 15:12:25 -0400
|
|
Subject: [PATCH] term: Fix overflow on user inputs
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
This requires a very weird input from the serial interface but can cause
|
|
an overflow in input_buf (keys) overwriting the next variable (npending)
|
|
with the user choice:
|
|
|
|
(pahole output)
|
|
|
|
struct grub_terminfo_input_state {
|
|
int input_buf[6]; /* 0 24 */
|
|
int npending; /* 24 4 */ <- CORRUPT
|
|
...snip...
|
|
|
|
The magic string requires causing this is "ESC,O,],0,1,2,q" and we overflow
|
|
npending with "q" (aka increase npending to 161). The simplest fix is to
|
|
just to disallow overwrites input_buf, which exactly what this patch does.
|
|
|
|
Fixes: CID 292449
|
|
|
|
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
|
|
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
|
|
Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
|
|
---
|
|
grub-core/term/terminfo.c | 9 ++++++---
|
|
1 file changed, 6 insertions(+), 3 deletions(-)
|
|
|
|
diff --git a/grub-core/term/terminfo.c b/grub-core/term/terminfo.c
|
|
index d317efa36..5fa94c0c3 100644
|
|
--- a/grub-core/term/terminfo.c
|
|
+++ b/grub-core/term/terminfo.c
|
|
@@ -398,7 +398,7 @@ grub_terminfo_getwh (struct grub_term_output *term)
|
|
}
|
|
|
|
static void
|
|
-grub_terminfo_readkey (struct grub_term_input *term, int *keys, int *len,
|
|
+grub_terminfo_readkey (struct grub_term_input *term, int *keys, int *len, int max_len,
|
|
int (*readkey) (struct grub_term_input *term))
|
|
{
|
|
int c;
|
|
@@ -414,6 +414,9 @@ grub_terminfo_readkey (struct grub_term_input *term, int *keys, int *len,
|
|
if (c == -1) \
|
|
return; \
|
|
\
|
|
+ if (*len >= max_len) \
|
|
+ return; \
|
|
+ \
|
|
keys[*len] = c; \
|
|
(*len)++; \
|
|
}
|
|
@@ -602,8 +605,8 @@ grub_terminfo_getkey (struct grub_term_input *termi)
|
|
return ret;
|
|
}
|
|
|
|
- grub_terminfo_readkey (termi, data->input_buf,
|
|
- &data->npending, data->readkey);
|
|
+ grub_terminfo_readkey (termi, data->input_buf, &data->npending,
|
|
+ GRUB_TERMINFO_READKEY_MAX_LEN, data->readkey);
|
|
|
|
#if defined(__powerpc__) && defined(GRUB_MACHINE_IEEE1275)
|
|
if (data->npending == 1 && data->input_buf[0] == GRUB_TERM_ESC
|
|
--
|
|
2.26.2
|
|
|