kumquat-buildroot/package/linphone/Config.in
Thomas De Schampheleire be084204eb Config.in files: add missing dependencies to toolchain option comments
When a package A depends on config option B and toolchain option C, then
the comment that is given when C is not fulfilled should also depend on B.
For example:

config BR2_PACKAGE_A
	depends on BR2_B
	depends on BR2_LARGEFILE
	depends on BR2_WCHAR

comment "A needs a toolchain w/ largefile, wchar"
	depends on !BR2_LARGEFILE || !BR2_WCHAR

This comment should actually be:

comment "A needs a toolchain w/ largefile, wchar"
	depends on BR2_B
	depends on !BR2_LARGEFILE || !BR2_WCHAR

or if possible (typically when B is a package config option declared in that
same Config.in file):

if BR2_B

comment "A needs a toolchain w/ largefile, wchar"
	depends on !BR2_LARGEFILE || !BR2_WCHAR

[other config options depending on B]

endif

Otherwise, the comment would be visible even though the other dependencies
are not met.

This patch adds such missing dependencies, and changes existing such
dependencies from
  depends on BR2_BASE_DEP && !BR2_TOOLCHAIN_USES_GLIBC
to
  depends on BR2_BASE_DEP
  depends on !BR2_TOOLCHAIN_USES_GLIBC
so that (positive) base dependencies are separate from the (negative)
toolchain dependencies. This strategy makes it easier to write such comments
(because one can simply copy the base dependency from the actual package
config option), but also avoids complex and long boolean expressions.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 (untested)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2013-11-10 23:59:57 +01:00

33 lines
1.2 KiB
Plaintext

config BR2_PACKAGE_LINPHONE
bool "linphone"
select BR2_PACKAGE_LIBEXOSIP2
select BR2_PACKAGE_SPEEX
select BR2_PACKAGE_ORTP
select BR2_PACKAGE_MEDIASTREAMER
depends on BR2_INSTALL_LIBSTDCPP # mediastreamer
depends on BR2_TOOLCHAIN_HAS_THREADS # ortp
depends on BR2_USE_MMU # libeXosip2
depends on BR2_INET_IPV6 # mediastreamer
help
Linphone is an internet phone or Voice Over IP phone (VoIP).
With linphone you can communicate freely with people over
the internet, with voice, video, and text instant messaging.
Linphone makes use of the SIP protocol, an open standard
for internet telephony. You can use Linphone with any SIP
VoIP operator, including our free SIP audio/video service.
linphone is free-software (or open-source), you can download
and redistribute it freely.
Linphone is available for desktop computers: Linux, Windows,
MacOSX, and for mobile phones: Android, iPhone, Blackberry.
Linphone support in Buildroot is limited to the commandline
client, linphonec, and video support is not enabled.
http://www.linphone.org/
comment "linphone needs a toolchain w/ threads, C++, IPv6"
depends on BR2_USE_MMU
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
!BR2_INET_IPV6