6a612fc8c6
glibc versions prior to 2.23 have a <fts.h> implementation that is not compatible with large file support, causing build failures such as: In file included from selinux_restorecon.c:17:0: /home/naourr/work/instance-0/output-1/host/arm-buildroot-linux-gnueabi/sysroot/usr/include/fts.h:41:3: error: #error "<fts.h> cannot be used with -D_FILE_OFFSET_BITS==64" # error "<fts.h> cannot be used with -D_FILE_OFFSET_BITS==64" Prior to commit3fce6f1c15("package/libselinux: fix the build with Python 3.8"), we were not passing PKG_PYTHON_DISTUTILS_ENV in the environment. But with3fce6f1c15, we are now passing the PKG_PYTHON_DISTUTILS_ENV variable, provided by pkg-python.mk, into the build environment. While this is part of fixing the build of libselinux with Python 3.8, it breaks the build because we are no longer filtering out the -D_FILE_OFFSET_BITS=64 option from CFLAGS. Indeed, while we do so at the beginning of libselinux.mk, it gets overridden later by the addition of $(PKG_PYTHON_DISTUTILS_ENV). To avoid this, we pass CFLAGS/LDFLAGS *after* $(PKG_PYTHON_DISTUTILS_ENV) has been added. In practice, the CFLAGS/LDFLAGS passed by $(PKG_PYTHON_DISTUTILS_ENV) are just $(TARGET_CFLAGS) and $(TARGET_LDFLAGS), so we are not missing anything specific. Fixes: http://autobuild.buildroot.net/results/ef6ff91086a094eb25b145d66d072c6d2fc60154/ Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
121 lines
3.7 KiB
Makefile
121 lines
3.7 KiB
Makefile
################################################################################
|
|
#
|
|
# libselinux
|
|
#
|
|
################################################################################
|
|
|
|
LIBSELINUX_VERSION = 2.9
|
|
LIBSELINUX_SITE = https://github.com/SELinuxProject/selinux/releases/download/20190315
|
|
LIBSELINUX_LICENSE = Public Domain
|
|
LIBSELINUX_LICENSE_FILES = LICENSE
|
|
|
|
LIBSELINUX_DEPENDENCIES = libsepol pcre
|
|
|
|
LIBSELINUX_INSTALL_STAGING = YES
|
|
|
|
# Set SHLIBDIR to /usr/lib so it has the same value than LIBDIR, as a result
|
|
# we won't have to use a relative path in 0002-revert-ln-relative.patch
|
|
LIBSELINUX_MAKE_OPTS = \
|
|
$(TARGET_CONFIGURE_OPTS) \
|
|
ARCH=$(KERNEL_ARCH) \
|
|
SHLIBDIR=/usr/lib
|
|
|
|
LIBSELINUX_MAKE_INSTALL_TARGETS = install
|
|
|
|
ifeq ($(BR2_TOOLCHAIN_USES_GLIBC),)
|
|
LIBSELINUX_DEPENDENCIES += musl-fts
|
|
LIBSELINUX_MAKE_OPTS += FTS_LDLIBS=-lfts
|
|
endif
|
|
|
|
ifeq ($(BR2_PACKAGE_PYTHON)$(BR2_PACKAGE_PYTHON3),y)
|
|
ifeq ($(BR2_PACKAGE_PYTHON3),y)
|
|
LIBSELINUX_DEPENDENCIES += python3 host-swig
|
|
LIBSELINUX_PYLIBVER = python$(PYTHON3_VERSION_MAJOR)
|
|
else ifeq ($(BR2_PACKAGE_PYTHON),y)
|
|
LIBSELINUX_DEPENDENCIES += python host-swig
|
|
LIBSELINUX_PYLIBVER = python$(PYTHON_VERSION_MAJOR)
|
|
endif
|
|
|
|
LIBSELINUX_MAKE_OPTS += \
|
|
$(PKG_PYTHON_DISTUTILS_ENV) \
|
|
PYTHON=$(LIBSELINUX_PYLIBVER)
|
|
|
|
LIBSELINUX_MAKE_INSTALL_TARGETS += install-pywrap
|
|
|
|
# dependencies are broken and result in file truncation errors at link
|
|
# time if the Python bindings are built through the same make
|
|
# invocation as the rest of the library.
|
|
define LIBSELINUX_BUILD_PYTHON_BINDINGS
|
|
$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
|
|
$(LIBSELINUX_MAKE_OPTS) swigify pywrap
|
|
endef
|
|
endif # python || python3
|
|
|
|
# Filter out D_FILE_OFFSET_BITS=64. This fixes errors caused by glibc
|
|
# 2.22. We set CFLAGS and LDFLAGS here because we want to win over the
|
|
# CFLAGS/LDFLAGS definitions passed by $(PKG_PYTHON_DISTUTILS_ENV)
|
|
# when the python binding is enabled.
|
|
LIBSELINUX_MAKE_OPTS += \
|
|
CFLAGS="$(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))" \
|
|
LDFLAGS="$(TARGET_LDFLAGS) -lpcre -lpthread"
|
|
|
|
define LIBSELINUX_BUILD_CMDS
|
|
$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
|
|
$(LIBSELINUX_MAKE_OPTS) all
|
|
$(LIBSELINUX_BUILD_PYTHON_BINDINGS)
|
|
endef
|
|
|
|
define LIBSELINUX_INSTALL_STAGING_CMDS
|
|
$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
|
|
$(LIBSELINUX_MAKE_OPTS) DESTDIR=$(STAGING_DIR) \
|
|
$(LIBSELINUX_MAKE_INSTALL_TARGETS)
|
|
endef
|
|
|
|
define LIBSELINUX_INSTALL_TARGET_CMDS
|
|
$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
|
|
$(LIBSELINUX_MAKE_OPTS) DESTDIR=$(TARGET_DIR) \
|
|
$(LIBSELINUX_MAKE_INSTALL_TARGETS)
|
|
# Create the selinuxfs mount point
|
|
if [ ! -d "$(TARGET_DIR)/selinux" ]; then mkdir $(TARGET_DIR)/selinux; fi
|
|
if ! grep -q "selinuxfs" $(TARGET_DIR)/etc/fstab; then \
|
|
echo "none /selinux selinuxfs noauto 0 0" >> $(TARGET_DIR)/etc/fstab ; fi
|
|
endef
|
|
|
|
HOST_LIBSELINUX_DEPENDENCIES = \
|
|
host-libsepol host-pcre host-swig
|
|
|
|
ifeq ($(BR2_PACKAGE_PYTHON3),y)
|
|
HOST_LIBSELINUX_DEPENDENCIES += host-python3
|
|
HOST_LIBSELINUX_PYLIBVER = python$(PYTHON3_VERSION_MAJOR)
|
|
else
|
|
HOST_LIBSELINUX_DEPENDENCIES += host-python
|
|
HOST_LIBSELINUX_PYLIBVER = python$(PYTHON_VERSION_MAJOR)
|
|
endif
|
|
|
|
HOST_LIBSELINUX_MAKE_OPTS = \
|
|
$(HOST_CONFIGURE_OPTS) \
|
|
PREFIX=$(HOST_DIR) \
|
|
SHLIBDIR=$(HOST_DIR)/lib \
|
|
LDFLAGS="$(HOST_LDFLAGS) -lpcre -lpthread" \
|
|
$(HOST_PKG_PYTHON_DISTUTILS_ENV) \
|
|
PYTHON=$(HOST_LIBSELINUX_PYLIBVER)
|
|
|
|
define HOST_LIBSELINUX_BUILD_CMDS
|
|
$(HOST_MAKE_ENV) $(MAKE1) -C $(@D) \
|
|
$(HOST_LIBSELINUX_MAKE_OPTS) all
|
|
# Generate python interface wrapper
|
|
$(HOST_MAKE_ENV) $(MAKE1) -C $(@D) \
|
|
$(HOST_LIBSELINUX_MAKE_OPTS) swigify pywrap
|
|
endef
|
|
|
|
define HOST_LIBSELINUX_INSTALL_CMDS
|
|
$(HOST_MAKE_ENV) $(MAKE) -C $(@D) \
|
|
$(HOST_LIBSELINUX_MAKE_OPTS) install
|
|
# Install python interface wrapper
|
|
$(HOST_MAKE_ENV) $(MAKE) -C $(@D) \
|
|
$(HOST_LIBSELINUX_MAKE_OPTS) install-pywrap
|
|
endef
|
|
|
|
$(eval $(generic-package))
|
|
$(eval $(host-generic-package))
|