f0417f965f
When readline is static library, we need to link against ncurses, it is because, dependent library's symbols are not resolved when static library is built. Those symbols are resolved when binary tries to link with static library. We can't pass linker flags for ncurses by setting LIBS environment variable via <PKG>_CONF_ENV because it looks like build system is not taking that into account and even though it would have been, order of linking is important. We can't also pass linker flags for ncurses via --with-readline-libs conf options because it causes lftp_LIB_READLINE macro to take readline headers from host machine if available. To use --with-readline-libs we need to set --with-readline=yes and --with-readline-inc to include dir. But when --with-readline=yes, readline_prefix is computed based on if headers can be found in /usr/local or /usr. If readline is installed on host machine, then configure fails since we are using headers for host machine. If headers are not found in /usr/local or /usr then only path specified --with-readline-inc is taken into account. So specifying linker flags for ncurses via --with-readline-libs will not work in all cases. So it looks like, updating linker flags directly is only option to fix static link issue against readline. Fixes: http://autobuild.buildroot.net/results/ae9/ae93bd1b4f6e1ed8f386830d4a51f00d9466f267/ Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com> [Thomas: update autoreconf comment in .mk file.] Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
69 lines
1.9 KiB
Makefile
69 lines
1.9 KiB
Makefile
################################################################################
|
|
#
|
|
# lftp
|
|
#
|
|
################################################################################
|
|
|
|
LFTP_VERSION = 4.7.3
|
|
LFTP_SOURCE = lftp-$(LFTP_VERSION).tar.xz
|
|
LFTP_SITE = http://lftp.yar.ru/ftp
|
|
LFTP_LICENSE = GPLv3+
|
|
LFTP_LICENSE_FILES = COPYING
|
|
# Needed so that our libtool patch applies properly, and for patch
|
|
# 0001-fix-static-link-with-readline.patch.
|
|
LFTP_AUTORECONF = YES
|
|
LFTP_DEPENDENCIES = readline zlib host-pkgconf
|
|
|
|
# Help lftp finding readline and zlib
|
|
LFTP_CONF_OPTS = \
|
|
--with-readline=$(STAGING_DIR)/usr \
|
|
--with-zlib=$(STAGING_DIR)/usr
|
|
|
|
ifneq ($(BR2_STATIC_LIBS),y)
|
|
LFTP_CONF_OPTS += --with-modules
|
|
endif
|
|
|
|
ifeq ($(BR2_PACKAGE_EXPAT)$(BR2_PACKAGE_LFTP_PROTO_HTTP),yy)
|
|
LFTP_DEPENDENCIES += expat
|
|
endif
|
|
|
|
ifeq ($(BR2_PACKAGE_GNUTLS),y)
|
|
LFTP_DEPENDENCIES += gnutls
|
|
LFTP_CONF_OPTS += --with-gnutls
|
|
else
|
|
LFTP_CONF_OPTS += --without-gnutls
|
|
endif
|
|
|
|
ifeq ($(BR2_PACKAGE_OPENSSL),y)
|
|
LFTP_DEPENDENCIES += openssl
|
|
LFTP_CONF_OPTS += --with-openssl
|
|
else
|
|
LFTP_CONF_OPTS += --without-openssl
|
|
endif
|
|
|
|
# Remove /usr/share/lftp
|
|
define LFTP_REMOVE_DATA
|
|
$(RM) -fr $(TARGET_DIR)/usr/share/lftp
|
|
endef
|
|
|
|
LFTP_POST_INSTALL_TARGET_HOOKS += LFTP_REMOVE_DATA
|
|
|
|
# Optional commands and protocols
|
|
LFTP_MODULES_TO_REMOVE-$(BR2_PACKAGE_LFTP_CMD_MIRROR) += cmd-mirror.so
|
|
LFTP_MODULES_TO_REMOVE-$(BR2_PACKAGE_LFTP_CMD_SLEEP) += cmd-sleep.so
|
|
LFTP_MODULES_TO_REMOVE-$(BR2_PACKAGE_LFTP_CMD_TORRENT) += cmd-torrent.so
|
|
LFTP_MODULES_TO_REMOVE-$(BR2_PACKAGE_LFTP_PROTO_FISH) += proto-fish.so
|
|
LFTP_MODULES_TO_REMOVE-$(BR2_PACKAGE_LFTP_PROTO_FTP) += proto-ftp.so
|
|
LFTP_MODULES_TO_REMOVE-$(BR2_PACKAGE_LFTP_PROTO_HTTP) += proto-http.so
|
|
LFTP_MODULES_TO_REMOVE-$(BR2_PACKAGE_LFTP_PROTO_SFTP) += proto-sftp.so
|
|
|
|
define LFTP_REMOVE_MODULES
|
|
for f in $(LFTP_MODULES_TO_REMOVE-) ; do \
|
|
$(RM) -f $(TARGET_DIR)/usr/lib/lftp/$(LFTP_VERSION)/$$f ; \
|
|
done
|
|
endef
|
|
|
|
LFTP_POST_INSTALL_TARGET_HOOKS += LFTP_REMOVE_MODULES
|
|
|
|
$(eval $(autotools-package))
|