40bb37bd70
Using absolute paths within getdeveloperlib isn't very sensible, it
makes a lot more sense to handle everything as relative paths from the
top-level Buildroot source directory.
parse_developers() is changed to no longer take the base path as
argument: it is automatically calculated based on the location of
utils/getdeveloperlib.py. Then, the rest of the logic is adjusted to
use relative paths, and prepend them with the base "brpath" when
needed.
This commit allows pkg-stats to report correct developers information
even when executed from an out of tree directory.
Before this patch:
$ ~/buildroot/support/scripts/pkg-stats -p ipmitool --json out.json
$ cat out.json | jq '.packages.ipmitool.developers'
[]
$ cat out.json | jq '.defconfigs.stm32f469_disco'
{
"name": "stm32f469_disco",
"path": "configs/stm32f469_disco_defconfig",
"developers": []
}
After this patch:
$ ~/buildroot/support/scripts/pkg-stats -p ipmitool --json out.json
$ cat out.json | jq '.packages.ipmitool.developers'
[
"Floris Bos <bos@je-eigen-domein.nl>",
"Heiko Thiery <heiko.thiery@gmail.com>"
]
$ cat out.json | jq '.defconfigs.stm32f469_disco'
{
"name": "stm32f469_disco",
"path": "configs/stm32f469_disco_defconfig",
"developers": [
"Christophe Priouzeau <christophe.priouzeau@st.com>"
]
}
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Tested-by: Heiko Thiery <heiko.thiery@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
107 lines
3.2 KiB
Python
Executable File
107 lines
3.2 KiB
Python
Executable File
#!/usr/bin/env python
|
|
|
|
import argparse
|
|
import getdeveloperlib
|
|
import sys
|
|
import os
|
|
|
|
|
|
def parse_args():
|
|
parser = argparse.ArgumentParser()
|
|
parser.add_argument('patches', metavar='P', type=argparse.FileType('r'), nargs='*',
|
|
help='list of patches (use - to read patches from stdin)')
|
|
parser.add_argument('-a', dest='architecture', action='store',
|
|
help='find developers in charge of this architecture')
|
|
parser.add_argument('-p', dest='package', action='store',
|
|
help='find developers in charge of this package')
|
|
parser.add_argument('-f', dest='files', nargs='*',
|
|
help='find developers in charge of these files')
|
|
parser.add_argument('-c', dest='check', action='store_const',
|
|
const=True, help='list files not handled by any developer')
|
|
parser.add_argument('-e', dest='email', action='store_const',
|
|
const=True, help='only list affected developer email addresses')
|
|
return parser.parse_args()
|
|
|
|
|
|
def __main__():
|
|
args = parse_args()
|
|
|
|
# Check that only one action is given
|
|
action = 0
|
|
if args.architecture is not None:
|
|
action += 1
|
|
if args.package is not None:
|
|
action += 1
|
|
if args.files:
|
|
action += 1
|
|
if args.check:
|
|
action += 1
|
|
if len(args.patches) != 0:
|
|
action += 1
|
|
if action > 1:
|
|
print("Cannot do more than one action")
|
|
return
|
|
if action == 0:
|
|
print("No action specified")
|
|
return
|
|
|
|
devs = getdeveloperlib.parse_developers()
|
|
if devs is None:
|
|
sys.exit(1)
|
|
|
|
# Handle the check action
|
|
if args.check:
|
|
files = getdeveloperlib.check_developers(devs)
|
|
for f in files:
|
|
print(f)
|
|
|
|
# Handle the architecture action
|
|
if args.architecture is not None:
|
|
for dev in devs:
|
|
if args.architecture in dev.architectures:
|
|
print(dev.name)
|
|
return
|
|
|
|
# Handle the package action
|
|
if args.package is not None:
|
|
for dev in devs:
|
|
if args.package in dev.packages:
|
|
print(dev.name)
|
|
return
|
|
|
|
# Handle the files action
|
|
if args.files is not None:
|
|
for dev in devs:
|
|
for f in args.files:
|
|
if dev.hasfile(f):
|
|
print(dev.name)
|
|
break
|
|
|
|
# Handle the patches action
|
|
if len(args.patches) != 0:
|
|
(files, infras) = getdeveloperlib.analyze_patches(args.patches)
|
|
matching_devs = set()
|
|
for dev in devs:
|
|
# See if we have developers matching by package name
|
|
for f in files:
|
|
if dev.hasfile(f):
|
|
matching_devs.add(dev.name)
|
|
# See if we have developers matching by package infra
|
|
for i in infras:
|
|
if i in dev.infras:
|
|
matching_devs.add(dev.name)
|
|
|
|
if args.email:
|
|
for dev in matching_devs:
|
|
print(dev)
|
|
else:
|
|
result = "--to buildroot@buildroot.org"
|
|
for dev in matching_devs:
|
|
result += " --cc \"%s\"" % dev
|
|
|
|
if result != "":
|
|
print("git send-email %s" % result)
|
|
|
|
|
|
__main__()
|