f268f7131b
The Buildroot coding style defines one space around make assignments and
does not align the assignment symbols.
This patch does a bulk fix of offending packages. The package
infrastructures (or more in general assignments to calculated variable
names, like $(2)_FOO) are not touched.
Alignment of line continuation characters (\) is kept as-is.
The sed command used to do this replacement is:
find * -name "*.mk" | xargs sed -i \
-e 's#^\([A-Z0-9a-z_]\+\)\s*\([?:+]\?=\)\s*$#\1 \2#'
-e 's#^\([A-Z0-9a-z_]\+\)\s*\([?:+]\?=\)\s*\([^\\]\+\)$#\1 \2 \3#'
-e 's#^\([A-Z0-9a-z_]\+\)\s*\([?:+]\?=\)\s*\([^\\ \t]\+\s*\\\)\s*$#\1 \2 \3#'
-e 's#^\([A-Z0-9a-z_]\+\)\s*\([?:+]\?=\)\(\s*\\\)#\1 \2\3#'
Brief explanation of this command:
^\([A-Z0-9a-z_]\+\) a regular variable at the beginning of the line
\([?:+]\?=\) any assignment character =, :=, ?=, +=
\([^\\]\+\) any string not containing a line continuation
\([^\\ \t]\+\s*\\\) string, optional whitespace, followed by a
line continuation character
\(\s*\\\) optional whitespace, followed by a line
continuation character
Hence, the first subexpression handles empty assignments, the second
handles regular assignments, the third handles regular assignments with
line continuation, and the fourth empty assignments with line
continuation.
This expression was tested on following test text: (initial tab not
included)
FOO = spaces before
FOO = spaces before and after
FOO = tab before
FOO = tab and spaces before
FOO = tab after
FOO = tab and spaces after
FOO = spaces and tab after
FOO = \
FOO = bar \
FOO = bar space \
FOO = \
GENIMAGE_DEPENDENCIES = host-pkgconf libconfuse
FOO += spaces before
FOO ?= spaces before and after
FOO :=
FOO =
FOO =
FOO =
FOO =
$(MAKE1) CROSS_COMPILE=$(TARGET_CROSS) -C
AT91BOOTSTRAP3_DEFCONFIG = \
AXEL_DISABLE_I18N=--i18n=0
After this bulk change, following manual fixups were done:
- fix line continuation alignment in cegui06 and spice (the sed
expression leaves the number of whitespace between the value and line
continuation character intact, but the whitespace before that could have
changed, causing misalignment.
- qt5base was reverted, as this package uses extensive alignment which
actually makes the code more readable.
Finally, the end result was manually reviewed.
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Cc: Yann E. Morin <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
51 lines
1.5 KiB
Makefile
51 lines
1.5 KiB
Makefile
################################################################################
|
|
#
|
|
# sg3_utils
|
|
#
|
|
################################################################################
|
|
|
|
SG3_UTILS_VERSION = 1.39
|
|
SG3_UTILS_SOURCE = sg3_utils-$(SG3_UTILS_VERSION).tar.xz
|
|
SG3_UTILS_SITE = http://sg.danny.cz/sg/p
|
|
SG3_UTILS_LICENSE = BSD-3c
|
|
# utils progs are GPLv2+ licenced
|
|
ifeq ($(BR2_PACKAGE_SG3_UTILS_PROGS),y)
|
|
SG3_UTILS_LICENSE += GPLv2+
|
|
endif
|
|
SG3_UTILS_LICENSE_FILES = COPYING BSD_LICENSE
|
|
|
|
# install the libsgutils2 library
|
|
SG3_UTILS_INSTALL_STAGING = YES
|
|
|
|
ifeq ($(BR2_PACKAGE_SG3_UTILS_PROGS),)
|
|
define SG3_UTILS_REMOVE_PROGS
|
|
for prog in \
|
|
compare_and_write copy_results dd decode_sense \
|
|
emc_trespass format get_config \
|
|
get_lba_status ident inq logs luns map26 \
|
|
map sgm_dd modes opcodes sgp_dd persist prevent \
|
|
raw rbuf rdac read readcap read_block_limits \
|
|
read_buffer read_long reassign referrals \
|
|
rep_zones requests reset reset_wp rmsn rtpg safte sanitize \
|
|
sat_identify sat_phy_event sat_set_features scan \
|
|
senddiag ses start stpg sync test_rwbuf turs \
|
|
unmap verify vpd write_buffer write_long \
|
|
write_same wr_mode xcopy; do \
|
|
$(RM) $(TARGET_DIR)/usr/bin/sg_$${prog} ; \
|
|
done
|
|
for prog in \
|
|
logging_level mandat readcap ready satl start stop \
|
|
temperature; do \
|
|
$(RM) $(TARGET_DIR)/usr/bin/scsi_$${prog} ; \
|
|
done
|
|
for prog in \
|
|
sginfo sgm_dd sgp_dd; do \
|
|
$(RM) $(TARGET_DIR)/usr/bin/$${prog}; \
|
|
done
|
|
endef
|
|
|
|
SG3_UTILS_POST_INSTALL_TARGET_HOOKS += SG3_UTILS_REMOVE_PROGS
|
|
endif
|
|
|
|
$(eval $(autotools-package))
|