NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
38,153 Commits 5 Branches 387 Tags 143 MiB
Makefile 63.3%
Python 16.3%
C 9.1%
Shell 5.9%
PHP 2.7%
Other 2.3%
2114c29e91
Go to file
Yann E. MORIN 2114c29e91 Revert "pkg-download: remove explicit PKG_VERSION from github helper" 
This reverts commit 1e5a8916b2.

The idea was that the version string can be derived because we know the
package name.

However, this patch does not account for the fact that $(pkgname) always
points to the latest pacakge scanned, which in all other situation we're
using it, is the current package, because it is used inside one ot he
xxx-inner macros that are $(eval)ualed. So $(pkgname) is evaluated
"early" and gets the expected value.

However, the github value is not in one of those macros, so it gets
evaluated "late", when doing the actual download. So, by that time,
$(pkgname) will expand to the last package scanned, which is actuall the
manual (without a br2-external tree).

That would require that the _SITE variable be assigned with the :=
assignment operator. This is weird, because that would make it the only
variable to require that, but only when using the github helper, which
is even less obvious and would cause a lot of trouble...

The obvious fixup would seem to be to use $(PKG) instead, because that
already contains the upper-case package name that vcan be used as a
prefix to variables.

However, that does not work either, because we have a check that forbids
a trsailing slash in _SITE, check that is done in pacakge/pkg-generic,
inside the xxx-inner macro, during the $(eval) call.

And at that time, PKG is not yet defined, because it is only defined for
an actual recipe.

So we can't seem to have a workable solution. So, just revert the patch.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
Cc: Peter Korsgaard <peter@korsgaard.com>
Cc: Arnout Vandecappelle <arnout@mind.be>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2017-11-14 13:55:39 +01:00
arch arc/bfin: remove 60x cores 2017-10-02 21:45:04 +02:00
board board/pc: add documentation for testing with qemu 2017-10-22 16:29:07 +02:00
boot uboot: use local libfdt.h 2017-11-06 21:25:31 +01:00
configs orange-pi-one: bump kernel and uboot versions 2017-11-06 11:43:10 +01:00
docs Revert "pkg-download: remove explicit PKG_VERSION from github helper" 2017-11-14 13:55:39 +01:00
fs fs: add missing $$(sep) to pre- and post-command hooks code 2017-11-05 17:52:27 +01:00
linux linux: bump default to version 4.13.12 2017-11-08 13:21:47 +01:00
package Revert "pkg-download: remove explicit PKG_VERSION from github helper" 2017-11-14 13:55:39 +01:00
support support/config-fragments/autobuild: update toolchains for 2017.11-rc1 2017-11-11 23:38:05 +01:00
system skeleton: Rename skeleton-sysv to skeleton-init-sysv 2017-08-14 21:52:45 +02:00
toolchain toolchain/wrapper: fake __DATE_ and __TIME__ for older gcc 2017-10-22 16:10:37 +02:00
utils perl: bump to version 5.26.1 2017-09-28 22:04:48 +02:00
.defconfig
.flake8 .flake8: add config file for Python code style 2017-10-06 19:05:18 +02:00
.gitignore
.gitlab-ci.yml .gitlab-ci.yml: use gitlab 9.0 varaible names 2017-11-05 15:53:46 +01:00
.gitlab-ci.yml.in .gitlab-ci.yml: use gitlab 9.0 varaible names 2017-11-05 15:53:46 +01:00
CHANGES Update for 2017.11-rc2 2017-11-13 22:28:15 +01:00
Config.in toolchain/wrapper: fake __DATE_ and __TIME__ for older gcc 2017-10-22 16:10:37 +02:00
Config.in.legacy rfkill: remove package 2017-11-03 17:21:14 +01:00
COPYING
DEVELOPERS DEVELOPERS: add packages to Baruch Siach 2017-11-10 18:24:45 +01:00
Makefile Update for 2017.11-rc2 2017-11-13 22:28:15 +01:00
Makefile.legacy Remove BR2_DEPRECATED 2016-10-15 23:14:45 +02:00
README

README 

Buildroot is a simple, efficient and easy-to-use tool to generate embedded
Linux systems through cross-compilation.

The documentation can be found in docs/manual. You can generate a text
document with 'make manual-text' and read output/docs/manual/manual.text.
Online documentation can be found at http://buildroot.org/docs.html

To build and use the buildroot stuff, do the following:

1) run 'make menuconfig'
2) select the target architecture and the packages you wish to compile
3) run 'make'
4) wait while it compiles
5) find the kernel, bootloader, root filesystem, etc. in output/images

You do not need to be root to build or run buildroot.  Have fun!

Buildroot comes with a basic configuration for a number of boards. Run
'make list-defconfigs' to view the list of provided configurations.

Please feed suggestions, bug reports, insults, and bribes back to the
buildroot mailing list: buildroot@buildroot.org
You can also find us on #buildroot on Freenode IRC.

If you would like to contribute patches, please read
https://buildroot.org/manual.html#submitting-patches