NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
45,670 Commits 5 Branches 387 Tags 141 MiB
Makefile 64%
Python 15.3%
C 9.2%
Shell 6%
PHP 2.8%
Other 2.4%
1da0a84f78
Go to file
Thomas Petazzoni 1da0a84f78 package/netsurf: change how CFLAGS/LDFLAGS are passed 
Fixes:
http://autobuild.buildroot.net/results/eeb2863c6237aac8428e49a5ee514d43088b0fb8
http://autobuild.buildroot.net/results/f938fd1515f1d6e11b57aa6e314135789da52a44

In commit 6da049f8ae ("package/netsurf:
fix build"), the CC variable passed to netsurf's build system was
extended to pass some special -I and -L options needed for netsurf to
find its own headers/libraries.

Unfortunately, on some systems (including mine), it breaks the build,
due to:

  toolpath_ := $(shell /bin/which $(CC__))

when $(CC__) contains some -I/-L options, they are considered to be
options "to which", which causes the funny:

/usr/bin/make install --directory=libnslog HOST=arm-buildroot-linux-uclibcgnueabi PREFIX=/home/thomas/projets/outputs/shared-netsurf/build/netsurf-3.8/tmpusr Q=@ WARNFLAGS='-Wall -W -Wno-error' DESTDIR=
make[3]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
/bin/which: invalid option -- 'I'
/bin/which: invalid option -- '/'
/bin/which: invalid option -- 'h'
/bin/which: invalid option -- 'o'
/bin/which: invalid option -- 'm'
/bin/which: invalid option -- 'e'
/bin/which: invalid option -- '/'
/bin/which: invalid option -- 't'
/bin/which: invalid option -- 'h'
/bin/which: invalid option -- 'o'
/bin/which: invalid option -- 'm'
/bin/which: invalid option -- 's'
/bin/which: invalid option -- '/'
[...]
/bin/which: invalid option -- 'l'
/bin/which: invalid option -- 'b'
/bin/which: --read-alias, -i: Warning: stdin is a tty.

and the build simply hangs.

We cannot pass CFLAGS/LDFLAGS as make options, as they would override
the CFLAGS definitions in netsurf Makefiles. However, those Makefiles
use the construct:

CFLAGS := $(CFLAGS) -more-flags

so by passing CFLAGS and LDFLAGS through the make environment, which
can achieve our goal.

It is worth mentioning that it remains very fragile, because
CFLAGS/LDFLAGS are used both for building target objects but also some
host tools. The netsurf build system is really not good.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2019-05-14 23:13:26 +02:00
arch package/binutils: fix build error due to architecture name is incomplete 2019-04-20 16:16:39 +02:00
board board/pc: drop unused grub-efi.cfg file 2019-05-10 10:30:15 +02:00
boot boot/optee-os: install trusted shared libraries 2019-05-14 17:46:44 +02:00
configs configs/bananapi_m64: uboot needs host pylibfdt to build 2019-05-13 20:16:53 +02:00
docs docs/manual: clarify location of local.mk 2019-05-13 20:49:19 +02:00
fs core: remove show-dependency-tree 2019-05-07 23:06:05 +02:00
linux {linux, linux-headers}: bump 4.{9, 14, 19}.x / 5.{0, 1}.x series 2019-05-14 17:39:49 +02:00
package package/netsurf: change how CFLAGS/LDFLAGS are passed 2019-05-14 23:13:26 +02:00
support support/dependencies: Add hint for ArchLinux when host needs IA32 libs 2019-05-10 11:04:09 +02:00
system system/skeleton: remove password expiration from shadow 2019-03-20 23:06:29 +01:00
toolchain toolchain/toolchain-external-andes-nds32: disable static build 2019-05-07 17:02:53 +02:00
utils utils/genrandconfig: prevent selecting libffi on nds32 2019-04-17 21:17:42 +02:00
.defconfig arch: remove support for sh64 2016-09-08 22:15:15 +02:00
.flake8 .flake8: fix check for 80/132 columns 2019-04-10 12:31:33 +02:00
.gitignore
.gitlab-ci.yml config: add defconfig for orangepi-r1 2019-05-05 21:12:04 +02:00
.gitlab-ci.yml.in .gitlab-ci.yml: add trigger per job 2019-05-01 15:42:45 +02:00
CHANGES Update for 2019.05-rc1 2019-05-08 22:54:44 +02:00
Config.in toolchain: set the ssp gcc option in kconfig 2019-03-13 00:01:55 +01:00
Config.in.legacy Config.in.legacy: fix check-package warning 2019-05-05 23:55:11 +02:00
COPYING
DEVELOPERS DEVELOPERS: Drop support for some packages from Petr Vorel 2019-05-06 09:34:33 +02:00
Makefile Update for 2019.05-rc1 2019-05-08 22:54:44 +02:00
Makefile.legacy Remove BR2_DEPRECATED 2016-10-15 23:14:45 +02:00
README

README 

Buildroot is a simple, efficient and easy-to-use tool to generate embedded
Linux systems through cross-compilation.

The documentation can be found in docs/manual. You can generate a text
document with 'make manual-text' and read output/docs/manual/manual.text.
Online documentation can be found at http://buildroot.org/docs.html

To build and use the buildroot stuff, do the following:

1) run 'make menuconfig'
2) select the target architecture and the packages you wish to compile
3) run 'make'
4) wait while it compiles
5) find the kernel, bootloader, root filesystem, etc. in output/images

You do not need to be root to build or run buildroot.  Have fun!

Buildroot comes with a basic configuration for a number of boards. Run
'make list-defconfigs' to view the list of provided configurations.

Please feed suggestions, bug reports, insults, and bribes back to the
buildroot mailing list: buildroot@buildroot.org
You can also find us on #buildroot on Freenode IRC.

If you would like to contribute patches, please read
https://buildroot.org/manual.html#submitting-patches