kumquat-buildroot/package/liburcu/liburcu-0001-Only-blacklist-ARM-gcc-4.8.0-and-4.8.1.patch
Samuel Martin a1a86ebfba liburcu: disable build with gcc-4.8.x on ARM
Because of a gcc bug [1], liburcu checks for compiler version [2] and
stops the build prematurely if gcc-4.8.[0-2] is detected for ARM.

However a bug fix exists [3] and may be backported by ARM toolchain
providers; that's what is done in Buildroot [4] or Linaro [5].

So, this change:
- add a patch in liburcu to allow build with ARM gcc-4.8.2;
- adds a new hidden symbol to reflect the toolchain status with regard
  to this bug [1];
- and controls liburcu visibility.

However, a limitation of this is when the user is using a custom
toolchain; that's why the bug details have been added in the liburcu
help message.

[1] http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58854
[2] http://git.lttng.org/?p=userspace-rcu.git;a=commitdiff;h=4b79310
[3] http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=204665
[4] http://git.buildroot.net/buildroot/commit/?id=c443c2be1768ebbdcb76c55d0a08fd7c983488c8
[5] http://bazaar.launchpad.net/~linaro-toolchain-dev/gcc-linaro/4.8/revision/122147

[Peter: hide normal toolchain comment if bug, add comment explaining issue if bug]
Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-03-23 23:17:56 +01:00

41 lines
1.3 KiB
Diff

From 54d8fe7ae40902d6d38e670f4024092f53c14e1f Mon Sep 17 00:00:00 2001
From: Samuel Martin <s.martin49@gmail.com>
Date: Sat, 8 Mar 2014 13:19:14 +0100
Subject: [PATCH] Only blacklist ARM gcc 4.8.0 and 4.8.1
Since many ARM toolchain providers include the bug fix for PR58854 in
their latest releases based on gcc-4.8.2, then only blacklist gcc 4.8.0
and 4.8.1.
Signed-off-by: Samuel Martin <s.martin49@gmail.com>
---
urcu/compiler.h | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/urcu/compiler.h b/urcu/compiler.h
index 1e30903..56115f1 100644
--- a/urcu/compiler.h
+++ b/urcu/compiler.h
@@ -118,10 +118,17 @@
+ __GNUC_PATCHLEVEL__)
/*
+ * Official gcc releases from 4.8.0 to 4.8.2 have the following bug,
+ * however, many arm toolchain providers have the included the fix for
+ * their latest 4.8.2 releases.
+ * So, we only blacklist gcc 4.8.0 and 4.8.1.
+ * Unfortunately, this bug is not easy to test, so we rely on the
+ * knowledge of the user on its compiler.
+ *
* http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58854
*/
# ifdef __ARMEL__
-# if URCU_GCC_VERSION >= 40800 && URCU_GCC_VERSION <= 40802
+# if URCU_GCC_VERSION >= 40800 && URCU_GCC_VERSION <= 40801
# error Your gcc version produces clobbered frame accesses
# endif
# endif
--
1.9.0