kumquat-buildroot

NetCube-Systems-Austria/kumquat-buildroot

Go to file

Yann E. MORIN 02fe7c747b package/pkg-generic: don't exclude virtual packages from packages list Currently, with a configuration with an internal toolchain, and no other package is selected [0], especially when one wants to generate an SDK or a pre-built, pre-installed toolchain, running 'make' will only build glibc (and its dependencies), and not the full toolchain, as one would have expected, so there would be no host-final-gcc. The reason is that 'toolchain' is a virtual package, so it is excluded from PACKAGES, the list of packages enabled in the configuration. so it is not a dependency of target-finalize, and so nothing pulls it in the build. The reason for excluding virtual packages from that list is not obvious. When virtual packages were introduced in `7439824412` (packages: add infrastructure for virtual packages), there was no BR2_PACKAGE_FOO symbol for virtual packages (but there was BR2_PACKAGE_HAS_FOO), so there was no telling that the virtual package was enabled, like we had for the other kinds of packages (normal, bootloader, toolchain, or linux kernel). That caused issues, so in `f674c428c2` (core/pkg-virtual: do not check they are neabled [sic]), and then `3e1b33a534` (pkg-generic: improve incorrectly used package detection), we explicitly excluded the virtual packages from causing a build failure when something depended on them, as we could not yet now whether a virtual package was actually enabled or not. Then, in `842ba7ecef` (pkg-generic: fix rdepends and phony targets of virtual packages), we eventually associated a virtual package to is BR2_PACKAGE_HAS_FOO, which allows treating virtual packages like the other kinds of packages. There, we explicitly kept virtual packages out of the list, though (the reasoning was that virtual packages install nothing in host/ or target/, so they do not directly contribute to the final content, so we do not need to rsync them, so this was an optimisation). However, virtual packages are in fact actual generic packages, and it is possible for virtual packages to actually provide content for the final image. Even though we do not have any virtual package that has actual _INSTALL_CMDS, we still have udev that provides a user for example; virtual packages in br2-external trees may also very well provide install commands (e.g. to install files common to their various implementations). So, there is currently no technical reason to exclude virtual packages from PACKAGES, the list of packages enabled in the configuration. Drop the excluding condition, and always add enabled package, whatever their kind, to the list of enabled packages. [0] defconfig to reproduce the issue: BR2_INIT_NONE=y BR2_SYSTEM_BIN_SH_NONE=y # BR2_PACKAGE_BUSYBOX is not set # BR2_PACKAGE_IFUPDOWN_SCRIPTS is not set # BR2_TARGET_ROOTFS_TAR is not set Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>		2022-09-24 16:45:11 +02:00
arch
board	board/solidrun/macchiatobin: update BSP components version in documentation	2022-09-24 10:37:04 +02:00
boot
configs
docs
fs
linux
package	package/pkg-generic: don't exclude virtual packages from packages list	2022-09-24 16:45:11 +02:00
support	support/scripts/size-stats: count compiled python (.pyc) files	2022-09-24 10:34:30 +02:00
system
toolchain	Revert "toolchain/toolchain-external: update Arm AArch64 toolchain 11.2-2022.02"	2022-09-23 23:35:03 +02:00
utils
.clang-format
.defconfig
.flake8
.gitignore
.gitlab-ci.yml
.shellcheckrc
CHANGES
Config.in
Config.in.legacy
COPYING
DEVELOPERS	package/open-isns: new package	2022-09-24 16:40:21 +02:00
Makefile
Makefile.legacy
README

README

Buildroot is a simple, efficient and easy-to-use tool to generate embedded
Linux systems through cross-compilation.

The documentation can be found in docs/manual. You can generate a text
document with 'make manual-text' and read output/docs/manual/manual.text.
Online documentation can be found at http://buildroot.org/docs.html

To build and use the buildroot stuff, do the following:

1) run 'make menuconfig'
2) select the target architecture and the packages you wish to compile
3) run 'make'
4) wait while it compiles
5) find the kernel, bootloader, root filesystem, etc. in output/images

You do not need to be root to build or run buildroot.  Have fun!

Buildroot comes with a basic configuration for a number of boards. Run
'make list-defconfigs' to view the list of provided configurations.

Please feed suggestions, bug reports, insults, and bribes back to the
buildroot mailing list: buildroot@buildroot.org
You can also find us on #buildroot on OFTC IRC.

If you would like to contribute patches, please read
https://buildroot.org/manual.html#submitting-patches