Commit Graph

53 Commits

Author SHA1 Message Date
Arnout Vandecappelle
30f7fec0a8 genrandconfig: fix (some) pep8 warnings
Warnings fixed:
E731 do not assign a lambda expression, use a def
 -> urlopen_closing is defined with a def. urlopen is not used
    elsewhere so inlined.
E302 expected 2 blank lines
E501 line too long
 -> long lines due to a long string are NOT split
E701 multiple statements on one line (colon)
E722 do not use bare except'
 -> use "except Exception", so KeyInterrupt and SystemExit are still
    passed. We never intended to catch those.
E741 ambiguous variable name 'l'
 -> variable name is replaced with the much more descriptive
    toolchains_csv
E271 multiple spaces after keyword
E231 missing whitespace after ','

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2017-07-25 22:42:15 +02:00
Arnout Vandecappelle
59419cdac1 genrandconfig: use subprocess.check_output instead of Popen
Popen is more complicated and more difficult to understand.

check_output raises an exception if the exit code is non-zero, but
that's probably what we want if ldd can't be executed.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2017-07-25 22:41:57 +02:00
Arnout Vandecappelle
86ca7a04a8 utils/genrandconfig: new script
This script will be used by the autobuild-run script to generate the
configuration to test. It is put in the utils directory because it can
also be called directly to allow users to test things.

For now, it is a direct copy of the relevant functions from the
autobuild-run script. The only changes are:
- unneeded import statements are removed;
- code/decode wrappers are limited to decode_byte_list;
- __main__ handling is added.

For now, the only supported arguments are the ones needed for
autobuild-run.  Follow-up patches will refactor things and also change
the way the script is called. In this version, it can be called from the
autobuild-run script as:

  subprocess.call([os.path.join(srcdir, "utils/genrandconfig"),
                   "-i", str(kwargs['instance']),
                   "--toolchains-url", kwargs['toolchains_url']],
                  stdout=log, stderr=log)

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2017-07-25 22:41:35 +02:00