The recommended form is without the trailing slash, and will become
mandatory in a coming commit.
This avoids the need for the $$($(2)_SITE:/=) magic in package/pkg-generic.mk
to avoid double slashes in download URLs, like
"https://mosh.mit.edu//mosh-1.2.5.tar.gz".
^^
Note: this work has already been done in b0b9606530 a few
months ago and earlier in c7f4b96471 and 4a9eb20de8,
but no check has been added at that time to avoid new slashes to slip
in, and so they did. This time a patch will follow immediately to
prevent future mistakes from being unnoticed.
Mass-replaced with the following command:
git grep -l '_SITE.*/$' | xargs sed -i '/_SITE.*=/s|/$||'
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Fixes configure error due to missing c++
checking for library containing pthread_create... no
configure: error: libpthread is required but was not found
Quote from config.log:
configure:21552: checking for library containing pthread_create
configure:21583: false -o conftest -Os conftest.cpp -lintl >&5
[...]
ac_cv_env_CXX_set=set
ac_cv_env_CXX_value=false
using this defconfig
BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
BR2_PACKAGE_POWERTOP=y
Please note the number of .cpp files belonging to powertop
output/build/powertop-2.7$ find -iname *.cpp | wc -l
59
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Acked-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
BR2_PACKAGE_GETTEXT=y might be enabled even if BR2_NEEDS_GETTEXT is
not set, and in this case, we should not link against libintl, because
it may not exist, for example with glibc toolchains.
Fixes:
http://autobuild.buildroot.net/results/270/270018e2c9e3845a4015faa155325eea2cabe3d9/
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
[Thomas:
- fix commit title
- powertop wants libintl unconditionally, so make sure
BR2_PACKAGE_GETTEXT is selected when BR2_NEEDS_GETTEXT is set, and
add gettext to the dependencies.
- add missing comment about thread dependency.
- add missing dependency on host-pkgconf, without which powertop
cannot find libnl.
- patch src/Makefile.am to not pass -fstack-protector, which fails
to build if the toolchain does not have SSP support.
- rename patch powertop-autotune.patch to confirm to the patch
naming convention.]
Signed-off-by: Steven Noonan <steven@uplinklabs.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
