Commit Graph

6 Commits

Author SHA1 Message Date
Bernd Kuhls
a5a96576fa package/powertop: depends on c++
Fixes configure error due to missing c++

checking for library containing pthread_create... no
configure: error: libpthread is required but was not found

Quote from config.log:

configure:21552: checking for library containing pthread_create
configure:21583: false -o conftest    -Os    conftest.cpp -lintl  >&5
[...]
ac_cv_env_CXX_set=set
ac_cv_env_CXX_value=false

using this defconfig

BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
BR2_PACKAGE_POWERTOP=y

Please note the number of .cpp files belonging to powertop

output/build/powertop-2.7$ find -iname *.cpp | wc -l
59

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Acked-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2015-04-02 00:05:38 +02:00
Bernd Kuhls
29df1ee7ef package/powertop: handle ncursesw properly and depend on wchar
The powertop code uses some wide-char functions, so the package should
depend on wide-char support. Also, when wide-char support is
available, the wide-char variant of ncurses may be built, but powertop
detection logic isn't quite up to the game, so we help him a little
bit.

Thanks to Gustavo Zacarias for doing some additional investigation and
proposing the solution implemented in this patch.

Fixes
http://autobuild.buildroot.net/results/913/913cea22f8a8f5902d8da5f64c3fce056d66790f/
http://autobuild.buildroot.net/results/6e1/6e11fa2a7405a69c59ced046b92ff08660c4aab7/
http://autobuild.buildroot.net/results/1d3/1d3323b2afaefa7989854dbccf92015731199e66/
http://autobuild.buildroot.net/results/1e3/1e31d412d8b3a38a375ad0be8f696bee993ec297/
http://autobuild.buildroot.net/results/2ff/2ff511eb8d00b94aca68427446e2d0f6e4317a5a/
and maybe others

[Thomas:
 - do not force select NCURSES_WCHAR, instead improve the detection
   logic to properly use it when available. Solution provided by
   Gustavo.
 - improve the commit log.]

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2015-04-02 00:03:50 +02:00
Bernd Kuhls
5f0127bbea package/powertop: needs gettextize, 2nd try
If host-gettext was compiled before powertop it is picked up by autoreconf which
leads to a broken compile. To fix this unconditionally include host-gettext as
dependency and move

POWERTOP_GETTEXTIZE = YES

outside the if-clause for BR2_NEEDS_GETTEXT

Fixes
http://autobuild.buildroot.net/results/24e/24e312271cf07a8dd966b43f153a06ddc858a786/
http://autobuild.buildroot.net/results/511/511a1c76bfd0ebf637e5abcd6fecc4d6a683ed3e/
http://autobuild.buildroot.net/results/652/65246f6f71e67c2637efbe8bb6e501750629d5fb/

and many others

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2015-03-27 16:36:42 +01:00
Bernd Kuhls
87f228a4e1 package/powertop: needs gettextize
Fixes
http://autobuild.buildroot.net/results/8e7/8e7d1f039b57400b1a6f9c14755b35528a457031/
http://autobuild.buildroot.net/results/4e5/4e5a8f49c80c363b5fb35332e34206c9a4fe4120/
http://autobuild.buildroot.net/results/658/658e11f5b0bf3347a50a387b6271eb43c45025fb/
and many others

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2015-03-25 00:32:40 +01:00
Thomas Petazzoni
198734f00b powertop: only link against -lintl when needed
BR2_PACKAGE_GETTEXT=y might be enabled even if BR2_NEEDS_GETTEXT is
not set, and in this case, we should not link against libintl, because
it may not exist, for example with glibc toolchains.

Fixes:

  http://autobuild.buildroot.net/results/270/270018e2c9e3845a4015faa155325eea2cabe3d9/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2015-03-21 09:39:22 +01:00
Steven Noonan
0adc0e24ee powertop: new package
[Thomas:
  - fix commit title
  - powertop wants libintl unconditionally, so make sure
    BR2_PACKAGE_GETTEXT is selected when BR2_NEEDS_GETTEXT is set, and
    add gettext to the dependencies.
  - add missing comment about thread dependency.
  - add missing dependency on host-pkgconf, without which powertop
    cannot find libnl.
  - patch src/Makefile.am to not pass -fstack-protector, which fails
    to build if the toolchain does not have SSP support.
  - rename patch powertop-autotune.patch to confirm to the patch
    naming convention.]

Signed-off-by: Steven Noonan <steven@uplinklabs.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2015-03-20 16:28:27 +01:00