kumquat-buildroot

NetCube-Systems-Austria/kumquat-buildroot

Author SHA1 Message Date

Author	SHA1	Message	Date
Yann E. MORIN	556a0a1104	Revert "make: support: use `command -v' instead of` which'" This reverts commit `ca6a2907c2`. Switching to using 'command -v' instead of 'which', opened a can of worms that is hard to fix in a timely manner: - recursive call to 'make' from a post-build, post-iamge script, fails because of a redefinition of HOSTCC_NOCCACHE (a bug on its own that needs a separate fix anyway) [0]; - 'make' believeing it can call "simple" commands with execve() et al. instead of passing them through a shell via system(), and thus failing to find 'command' in the PATH [1]. [0] https://lore.kernel.org/buildroot/20211001175329.GA1973888@lbrmn-mmayer.ric.broadcom.net/T/#m95c17eb8374e4e3dd6eee700d397aa12cca0739e [1] https://lore.kernel.org/buildroot/20211001180304.GV1504958@scaer/T/#m3a8f36bd76ec7d8e5038a6c8932bb6ffe23ea268 Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>	2021-10-01 20:09:58 +02:00
Petr Vorel	ca6a2907c2	make: support: use `command -v' instead of` which' `which' has been discontinued after 2.21 release in 2015 due this (git repository is empty [1]) and version shipped in Debian produces warning [2]: /usr/bin/which: this version of `which' is deprecated; use `command -v' in scripts instead. `command is POSIX [3] and supported on all common shells (bash, zsh, dash, busybox sh, mksh). Patch tested on dash as the default shell. [1] https://git.savannah.gnu.org/cgit/which.git [2] `3a8dd10b45` [3] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/command.html Signed-off-by: Petr Vorel <petr.vorel@gmail.com> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>	2021-09-26 23:37:21 +02:00
Romain Naour	b60729784a	support/dependencies: add a check for python3 Since version 2.29, glibc requires python 3.4 or later to build the GNU C Library [1]. We add a new check to verify the version of python3 interpreter installed on the host. If no suitable python3 interpreter is found, define BR2_PYTHON3_HOST_DEPENDENCY to add host-python3 in package dependencies when needed. [1] https://www.sourceware.org/ml/libc-alpha/2019-01/msg00723.html Signed-off-by: Romain Naour <romain.naour@gmail.com> Tested-by: Adam Duskett <aduskett@gmail.com> Reviewed-by: Adam Duskett <aduskett@gmail.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> [Thomas: drop not so useful comment in the .mk file, as suggested by Yann E. Morin.] Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>	2019-03-15 22:26:40 +01:00

Yann E. MORIN

556a0a1104

Revert "make: support: use command -v' instead of which'"

This reverts commit ca6a2907c2.

Switching to using 'command -v' instead of 'which', opened a can of
worms that is hard to fix in a timely manner:

  - recursive call to 'make' from a post-build, post-iamge script, fails
    because of a redefinition of HOSTCC_NOCCACHE (a bug on its own that
    needs a separate fix anyway) [0];

  - 'make' believeing it can call "simple" commands with execve() et al.
    instead of passing them through a shell via system(), and thus
    failing to find 'command' in the PATH [1].

[0] https://lore.kernel.org/buildroot/20211001175329.GA1973888@lbrmn-mmayer.ric.broadcom.net/T/#m95c17eb8374e4e3dd6eee700d397aa12cca0739e
[1] https://lore.kernel.org/buildroot/20211001180304.GV1504958@scaer/T/#m3a8f36bd76ec7d8e5038a6c8932bb6ffe23ea268

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>

2021-10-01 20:09:58 +02:00

Petr Vorel

ca6a2907c2

make: support: use command -v' instead of which'

`which' has been discontinued after 2.21 release in 2015 due this (git
repository is empty [1]) and version shipped in Debian produces warning
[2]:

/usr/bin/which: this version of `which' is deprecated; use `command -v' in scripts instead.

`command is POSIX [3] and supported on all common shells (bash, zsh,
dash, busybox sh, mksh).

Patch tested on dash as the default shell.

[1] https://git.savannah.gnu.org/cgit/which.git
[2] 3a8dd10b45
[3] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/command.html

Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

2021-09-26 23:37:21 +02:00

Romain Naour

b60729784a

support/dependencies: add a check for python3

Since version 2.29, glibc requires python 3.4 or later to build the
GNU C Library [1].

We add a new check to verify the version of python3 interpreter
installed on the host.  If no suitable python3 interpreter is found,
define BR2_PYTHON3_HOST_DEPENDENCY to add host-python3 in package
dependencies when needed.

[1] https://www.sourceware.org/ml/libc-alpha/2019-01/msg00723.html

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Tested-by: Adam Duskett <aduskett@gmail.com>
Reviewed-by: Adam Duskett <aduskett@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
[Thomas: drop not so useful comment in the .mk file, as suggested by
Yann E. Morin.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

2019-03-15 22:26:40 +01:00

3 Commits