Commit Graph

2 Commits

Author SHA1 Message Date
Thomas Petazzoni
2a4ece2ed3 argp-standalone: fix build issue caused by UCHAR_MAX definition
The issue was simply that the patch from Max Filippov forgot to
include <limits.h> to get the definition of UCHAR_MAX.

Fixes:

  http://autobuild.buildroot.org/results/bd1/bd120ada4830fda3db96da945513d4f6f7b2d419/

and lots of similar build failures.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2015-05-01 16:20:07 +02:00
Max Filippov
30a3b08c17 argp-standalone: restrict value range passed to isprint function
According to C standards isprint argument shall be representable as an
unsigned char or be equal to EOF, otherwise the behaviour is undefined.

Passing arbitrary ints leads to segfault in nm program from elfutils.

Restrict isprint argument range to values representable by unsigned char.

Note: a similar change was done to the internal argp implementation of
glibc in commit
https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=9055724a92433ffa4c36f93d918ee1b3dfa1d6f7.

[Thomas: add a reference to the corresponding glibc fix.]

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2015-05-01 11:01:33 +02:00