Commit Graph

7 Commits

Author SHA1 Message Date
Thomas Petazzoni
d5507262f3 busybox: disable new TLS support
Busybox 1.17.1 has added built-in TLS support. Unfortunately, it fails
to build on i686 with gcc 4.8, with:

networking/tls_pstm_mul_comba.c: In function 'pstm_mul_comba':
networking/tls_pstm_mul_comba.c:82:1: error: 'asm' operand has impossible constraints
 asm(                                                      \
 ^
networking/tls_pstm_mul_comba.c:279:4: note: in expansion of macro 'MULADD'
    MULADD(*tmpx++, *tmpy--);
    ^
make[3]: *** [networking/tls_pstm_mul_comba.o] Error 1
make[2]: *** [networking] Error 2

Since TLS support is a new feature in 1.27, and wasn't present until
now, let's disable it to avoid the build failure.

The bug has been reported upstream at
http://lists.busybox.net/pipermail/busybox/2017-July/085713.html.

Fixes:

 http://autobuild.buildroot.net/results/d973f9a2fbf0f52104f4943b902183e9dbf163a7/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2017-07-30 15:44:46 +02:00
Adam Duskett
8cea293617 busybox: bump version to 1.27.1
In addition, update busybox-minimal.config and busybox.config by loading the
config files and saving them back.

Signed-off-by: Adam Duskett <aduskett@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2017-07-29 22:19:09 +02:00
Peter Korsgaard
15e8e721f6 busybox: disable CONFIG_FEATURE_CLEAN_UP in default configs
FEATURE_CLEAN_UP is a configuration feature to get busybox to explicitly
call free() on dynamic allocated memory just before exiting so memory leak
detectors like valgrind don't get confused.  Upstream explicitly recommends
to NOT enable this option:

config FEATURE_CLEAN_UP
	bool "Clean up all memory before exiting (usually not needed)"
	default n
	help
	  As a size optimization, busybox normally exits without explicitly
	  freeing dynamically allocated memory or closing files. This saves
	  space since the OS will clean up for us, but it can confuse debuggers
	  like valgrind, which report tons of memory and resource leaks.

	  Don't enable this unless you have a really good reason to clean
	  things up manually.

Having this option enabled adds a bit of bloat, but more significantly these
cleanup code paths don't get tested very often so some times get out of sync
with the allocation code which can lead to crashes (or security issues from
double frees), so it is safer to disable the option.

For people wanting to debug memory leak issues with busybox, the option can
still be enabled with a configuration fragment (or a custom config).

The size difference isn't huge (br-arm-full-static):

-rwxr-xr-x 1 peko peko 886K Jul  5 10:56 output-busybox1/target/bin/busybox
-rwxr-xr-x 1 peko peko 882K Jul  5 10:53 output-busybox2/target/bin/busybox

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2017-07-05 12:25:15 +02:00
Jörg Krause
8f55961eed package/busybox: update minimal configuration file
Commit 44a563dbc0 bumps busybox to version
1.26.0, but does not update the minimal configuration file. There is at
least one issue using the old configuration with the newer busybox:

* IFUPDOWN is split into IFUP and IFDOWN in version 1.26.0

Update the minimal configuration file by loading the busybox.config file
and saving it back.

Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2016-12-30 22:44:25 +01:00
Gustavo Zacarias
81cbdbaee8 busybox: bump to version 1.25.0
Also drop upstream patches.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2016-06-22 10:32:53 +02:00
Waldemar Brodkorb
cc72cf2ca6 m68k: fix open issues with qemu coldfire
Enable kernel drivers for networking and add a simple
busybox config with basic network tools.

Add kernel patch from Linux git to fix hush segfaults while
using signal handler.

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-05-11 15:27:15 +02:00
Waldemar Brodkorb
5e1b132495 move busybox-minimal.config to be used by other noMMU targets
Config can be used by other noMMU targets as qemu-system-m68k
with coldfire emulation.

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2016-04-30 15:28:32 +02:00