From f93039e3a6f0177675a4f775d762d665204714c9 Mon Sep 17 00:00:00 2001 From: James Hilliard Date: Sat, 5 Feb 2022 13:18:32 -0700 Subject: [PATCH] package/icu: don't disable renaming for host build Using a different renaming option for the icu host build can cause issues for packages such as qt5webengine which expect target and host packages to be built with the same options. A package that needs both host and target to have the same options is most probably doing somethig wrong, like linking a host program and taking the result as valid for the target. However, our adding the --disable-renaming in the first place in 3911e67151b (icu: security bump to version 51.2) did not provide any explanations why it was needed to begin with, so drop it. Signed-off-by: James Hilliard Reviewed-by: Yann E. MORIN [Peter: extend commit message as suggested by Yann] Signed-off-by: Peter Korsgaard --- package/icu/icu.mk | 3 +-- package/nodejs/nodejs.mk | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/package/icu/icu.mk b/package/icu/icu.mk index 7e0c96e43a..ebbb1968fc 100644 --- a/package/icu/icu.mk +++ b/package/icu/icu.mk @@ -45,8 +45,7 @@ HOST_ICU_CONF_OPTS = \ --disable-tests \ --disable-extras \ --disable-icuio \ - --disable-layout \ - --disable-renaming + --disable-layout ICU_SUBDIR = source HOST_ICU_SUBDIR = source diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk index 727af6dc50..2e41c11dbd 100644 --- a/package/nodejs/nodejs.mk +++ b/package/nodejs/nodejs.mk @@ -94,7 +94,7 @@ NODEJS_HOST_TOOLS_V8 = \ NODEJS_HOST_TOOLS_NODE = mkcodecache NODEJS_HOST_TOOLS = $(NODEJS_HOST_TOOLS_V8) $(NODEJS_HOST_TOOLS_NODE) -HOST_NODEJS_CXXFLAGS = $(HOST_CXXFLAGS) -DU_DISABLE_RENAMING=1 +HOST_NODEJS_CXXFLAGS = $(HOST_CXXFLAGS) define HOST_NODEJS_BUILD_CMDS $(HOST_MAKE_ENV) PYTHON=$(HOST_DIR)/bin/python3 \