diff --git a/package/icu/0005-ICU-21587-Fix-memory-bug-w-baseName.patch b/package/icu/0005-ICU-21587-Fix-memory-bug-w-baseName.patch new file mode 100644 index 0000000000..15af976e49 --- /dev/null +++ b/package/icu/0005-ICU-21587-Fix-memory-bug-w-baseName.patch @@ -0,0 +1,112 @@ +From 2dc5bea9061b4fb05cd03e21b775dd944a0eb81d Mon Sep 17 00:00:00 2001 +From: Frank Tang +Date: Tue, 13 Apr 2021 15:16:50 -0700 +Subject: [PATCH] ICU-21587 Fix memory bug w/ baseName + +Edge cases not fixed in assign and move assign operator +while the locale is long and call setKeywordValue with incorrect +keyword/values. + +Signed-off-by: Peter Korsgaard +[Peter: Fixes CVE-2021-30535, adjust paths for tarball] +--- + source/common/locid.cpp | 11 +++++++++-- + source/test/intltest/loctest.cpp | 26 ++++++++++++++++++++++++++ + source/test/intltest/loctest.h | 2 ++ + 3 files changed, 37 insertions(+), 2 deletions(-) + +diff --git a/source/common/locid.cpp b/source/common/locid.cpp +index 02cd82a7b8..3c6e5b0669 100644 +--- a/source/common/locid.cpp ++++ b/source/common/locid.cpp +@@ -469,14 +469,18 @@ Locale& Locale::operator=(Locale&& other) U_NOEXCEPT { + if ((baseName != fullName) && (baseName != fullNameBuffer)) uprv_free(baseName); + if (fullName != fullNameBuffer) uprv_free(fullName); + +- if (other.fullName == other.fullNameBuffer) { ++ if (other.fullName == other.fullNameBuffer || other.baseName == other.fullNameBuffer) { + uprv_strcpy(fullNameBuffer, other.fullNameBuffer); ++ } ++ if (other.fullName == other.fullNameBuffer) { + fullName = fullNameBuffer; + } else { + fullName = other.fullName; + } + +- if (other.baseName == other.fullName) { ++ if (other.baseName == other.fullNameBuffer) { ++ baseName = fullNameBuffer; ++ } else if (other.baseName == other.fullName) { + baseName = fullName; + } else { + baseName = other.baseName; +@@ -2681,6 +2685,9 @@ Locale::setKeywordValue(const char* keywordName, const char* keywordValue, UErro + if (fullName != fullNameBuffer) { + // if full Name is already on the heap, need to free it. + uprv_free(fullName); ++ if (baseName == fullName) { ++ baseName = newFullName; // baseName should not point to freed memory. ++ } + } + fullName = newFullName; + status = U_ZERO_ERROR; +diff --git a/source/test/intltest/loctest.cpp b/source/test/intltest/loctest.cpp +index ce41a4c00e..5503b008b0 100644 +--- a/source/test/intltest/loctest.cpp ++++ b/source/test/intltest/loctest.cpp +@@ -284,6 +284,8 @@ void LocaleTest::runIndexedTest( int32_t index, UBool exec, const char* &name, c + TESTCASE_AUTO(TestSetUnicodeKeywordValueNullInLongLocale); + TESTCASE_AUTO(TestCanonicalize); + TESTCASE_AUTO(TestLeak21419); ++ TESTCASE_AUTO(TestLongLocaleSetKeywordAssign); ++ TESTCASE_AUTO(TestLongLocaleSetKeywordMoveAssign); + TESTCASE_AUTO_END; + } + +@@ -6520,6 +6522,30 @@ void LocaleTest::TestSetUnicodeKeywordValueInLongLocale() { + } + } + ++void LocaleTest::TestLongLocaleSetKeywordAssign() { ++ IcuTestErrorCode status(*this, "TestLongLocaleSetKeywordAssign"); ++ // A long base name, with an illegal keyword and copy constructor ++ icu::Locale l("de_AAAAAAA1_AAAAAAA2_AAAAAAA3_AAAAAAA4_AAAAAAA5_AAAAAAA6_" ++ "AAAAAAA7_AAAAAAA8_AAAAAAA9_AAAAAA10_AAAAAA11_AAAAAA12_" ++ "AAAAAA13_AAAAAA14_AAAAAA15_AAAAAA16_AAAAAA17_AAAAAA18"); ++ Locale l2; ++ l.setUnicodeKeywordValue("co", "12", status); // Cause an error ++ status.reset(); ++ l2 = l; // copy operator on such bogus locale. ++} ++ ++void LocaleTest::TestLongLocaleSetKeywordMoveAssign() { ++ IcuTestErrorCode status(*this, "TestLongLocaleSetKeywordMoveAssign"); ++ // A long base name, with an illegal keyword and copy constructor ++ icu::Locale l("de_AAAAAAA1_AAAAAAA2_AAAAAAA3_AAAAAAA4_AAAAAAA5_AAAAAAA6_" ++ "AAAAAAA7_AAAAAAA8_AAAAAAA9_AAAAAA10_AAAAAA11_AAAAAA12_" ++ "AAAAAA13_AAAAAA14_AAAAAA15_AAAAAA16_AAAAAA17"); ++ Locale l2; ++ l.setUnicodeKeywordValue("co", "12", status); // Cause an error ++ status.reset(); ++ Locale l3 = std::move(l); // move assign ++} ++ + void LocaleTest::TestSetUnicodeKeywordValueNullInLongLocale() { + IcuTestErrorCode status(*this, "TestSetUnicodeKeywordValueNullInLongLocale"); + const char *exts[] = {"cf", "cu", "em", "kk", "kr", "ks", "kv", "lb", "lw", +diff --git a/source/test/intltest/loctest.h b/source/test/intltest/loctest.h +index 05be4037bd..12a93bde53 100644 +--- a/source/test/intltest/loctest.h ++++ b/source/test/intltest/loctest.h +@@ -156,6 +156,8 @@ class LocaleTest: public IntlTest { + void TestSetUnicodeKeywordValueInLongLocale(); + void TestSetUnicodeKeywordValueNullInLongLocale(); + void TestLeak21419(); ++ void TestLongLocaleSetKeywordAssign(); ++ void TestLongLocaleSetKeywordMoveAssign(); + + private: + void _checklocs(const char* label, +-- +2.20.1 + diff --git a/package/icu/icu.mk b/package/icu/icu.mk index 0a17c61462..2c04c3c775 100644 --- a/package/icu/icu.mk +++ b/package/icu/icu.mk @@ -17,6 +17,9 @@ ICU_CPE_ID_VENDOR = icu-project ICU_CPE_ID_PRODUCT = international_components_for_unicode ICU_CPE_ID_VERSION = $(subst -,.,$(ICU_VERSION)) +# 0005-ICU-21587-Fix-memory-bug-w-baseName.patch +ICU_IGNORE_CVES += CVE-2021-30535 + ICU_DEPENDENCIES = host-icu ICU_INSTALL_STAGING = YES ICU_CONFIG_SCRIPTS = icu-config