NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

package/fxload: re-enable package on microblaze

Browse Source 
Building fxload on Microblaze with gcc < 8.x and optimization enabled
fails with:

  Error: operation combines symbols in different segments

This is due to gcc bug 63261
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63261).

To work around this, the fxload package has a !BR2_microblaze
dependency. However, gcc bug 63261 only triggers when optimization is
enabled, so a better work around is to pass -O0, which is what we do
in other Buildroot packages to work around this bug.

So, this commit passes -O0 when BR2_TOOLCHAIN_HAS_GCC_BUG_63261, and
re-enables fxload on Microblaze.

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
This commit is contained in:
Giulio Benetti 2019-06-14 23:03:38 +02:00 committed by Thomas Petazzoni
parent 4adc06b4f8
commit f00d6ddf50
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
package/fxload/Config.in
View File

@ -1,9 +1,5 @@
config BR2_PACKAGE_FXLOAD
bool "fxload"
# Hits gcc PR63261 on Microblaze with debugging symbols
# enabled. Since this package is unlikely to be useful on
# Microblaze, just disable it on this architecture.
depends on !BR2_microblaze
help
This program is conveniently able to download firmware into
FX, FX2, and FX2LP EZ-USB devices, as well as the original

9
package/fxload/fxload.mk
View File

@ -9,8 +9,15 @@ FXLOAD_SITE = http://downloads.sourceforge.net/project/linux-hotplug/fxload/$(FX
FXLOAD_LICENSE = GPL-2.0+
FXLOAD_LICENSE_FILES = COPYING
FXLOAD_CFLAGS = $(TARGET_CFLAGS)
ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_63261),y)
FXLOAD_CFLAGS += -O0
endif
define FXLOAD_BUILD_CMDS
$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) all
$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
CFLAGS="$(FXLOAD_CFLAGS)" -C $(@D) all
endef
define FXLOAD_INSTALL_TARGET_CMDS