diff --git a/package/gitlab-runner/S95gitlab-runner b/package/gitlab-runner/S95gitlab-runner index 2a50e7151a..739adf1783 100644 --- a/package/gitlab-runner/S95gitlab-runner +++ b/package/gitlab-runner/S95gitlab-runner @@ -3,7 +3,7 @@ DAEMON="gitlab-runner" PIDFILE="/var/run/$DAEMON.pid" -GITLAB_RUNNER_ARGS="run" +DAEMON_ARGS="run --syslog --user gitlab-runner -d /var/lib/gitlab-runner -c /etc/gitlab-runner/config.toml" # shellcheck source=/dev/null [ -r "/etc/default/$DAEMON" ] && . "/etc/default/$DAEMON" @@ -11,8 +11,8 @@ GITLAB_RUNNER_ARGS="run" start() { printf 'Starting %s: ' "$DAEMON" # shellcheck disable=SC2086 # we need the word splitting - start-stop-daemon -S -q -m -b -p "$PIDFILE" -c "$DAEMON:$DAEMON" -x "/usr/bin/$DAEMON" \ - -- $GITLAB_RUNNER_ARGS + start-stop-daemon -S -q -m -b -p "$PIDFILE" -x "/usr/bin/$DAEMON" \ + -- $DAEMON_ARGS status=$? if [ "$status" -eq 0 ]; then echo "OK" diff --git a/package/gitlab-runner/gitlab-runner.mk b/package/gitlab-runner/gitlab-runner.mk index fde776e631..9542275135 100644 --- a/package/gitlab-runner/gitlab-runner.mk +++ b/package/gitlab-runner/gitlab-runner.mk @@ -12,9 +12,8 @@ GITLAB_RUNNER_LICENSE_FILES = LICENSE GITLAB_RUNNER_LDFLAGS = \ -X gitlab.com/gitlab-org/gitlab-runner/common.VERSION=$(GITLAB_RUNNER_VERSION) -# Don't run gitlab runner as root. define GITLAB_RUNNER_USERS - gitlab-runner -1 gitlab-runner -1 * /var/run/dbus /bin/false - Gitlab Runner + gitlab-runner -1 gitlab-runner -1 * /var/lib/gitlab-runner /bin/false - Gitlab Runner endef define GITLAB_RUNNER_INSTALL_INIT_SYSV