From eb3ee3078a76bb86428babb76d30eb6201814ccf Mon Sep 17 00:00:00 2001 From: Edgar Bonet Date: Tue, 5 Oct 2021 19:17:58 +0200 Subject: [PATCH] support/testing/infra/emulator.py: prevent the commands from wrapping Traditional VT-10x terminals (and their emulators) [0] have a "magic margins" feature that enables the last character position to be updated without scrolling the screen: whenever a character is printed on the last column, the cursor stays over the character, instead of moving to the next line. The Busybox shell, ash, attempts to defeat this feature by printing CR,LF right after echoing a character to the last column.[1] This doesn't play well with emulator.py. The run() method of the Emulator class captures the output of the emulated system and assumes the first line it reads is the echo of the command, and all subsequent lines are the command's output. If the line made by the command + shell prompt is longer than 80 characters, then it is echoed as two or more lines, and all but the first one are mistaken for the command's output. We fix this by telling the emulated system that we are using an ultra-wide terminal with 29999 columns. Larger values would be ignored and replaced by the default, namely 80 columns.[2] [0] https://vt100.net/docs/vt100-ug/chapter3.html - DECAWM [1] https://git.busybox.net/busybox/tree/libbb/lineedit.c?h=1_34_0#n412 [2] https://git.busybox.net/busybox/tree/libbb/xfuncs.c?h=1_34_0#n258 Signed-off-by: Edgar Bonet Reported-by: Thomas Petazzoni Co-authored-by: Yann E. MORIN Signed-off-by: Yann E. MORIN --- support/testing/infra/emulator.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/support/testing/infra/emulator.py b/support/testing/infra/emulator.py index 7ba1390ea5..53876f828c 100644 --- a/support/testing/infra/emulator.py +++ b/support/testing/infra/emulator.py @@ -101,6 +101,8 @@ class Emulator(object): if index != 0: raise SystemError("Cannot login") self.run("dmesg -n 1") + # Prevent the shell from wrapping the commands at 80 columns. + self.run("stty columns 29999") # Run the given 'cmd' with a 'timeout' on the target # return a tuple (output, exit_code)