NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

package/libzenoh-pico: disable on or1k

Browse Source 
The upstream libzenoh-pico code uses asm("nop"), which is completely
bogus, and actually breaks build on or1k as the instruction does not
exist.

In upstream commit
7d79a14add
they made the asm("nop") thing "configurable" with ZP_ASM_NOP, but
still that requires some special handling for or1k. The whole thing is
a complete mess, and upstream should have to use any of that. Rather
than stacking piles of bogus stuff on more bogus stuff, let's simply
disable this package for or1k for now.

Thanks a lot to Fabrice for all the investigation, and interaction
with upstream. See
https://patchwork.ozlabs.org/project/buildroot/patch/20240110215515.1263859-1-fontaine.fabrice@gmail.com/
for example.

Fixes:
 - http://autobuild.buildroot.org/results/fd0b2c666a1dc1537162d15b27743abd270243ed

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
This commit is contained in:
Thomas Petazzoni 2024-02-05 14:19:53 +01:00
parent eef5c297e7
commit ead797bef7
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
package/libzenoh-pico/Config.in
View File

@ -1,5 +1,8 @@
config BR2_PACKAGE_LIBZENOH_PICO
bool "libzenoh-pico"
# upstream hardcodes using asm("nop"), which is bogus and
# doesn't work on or1k
depends on !BR2_or1k
depends on BR2_TOOLCHAIN_HAS_THREADS
help
zenoh-pico is the Eclipse zenoh implementation that targets
@ -11,4 +14,5 @@ config BR2_PACKAGE_LIBZENOH_PICO
https://github.com/eclipse-zenoh/zenoh-pico
comment "libzenoh-pico needs a toolchain w/ threads"
depends on !BR2_or1k
depends on !BR2_TOOLCHAIN_HAS_THREADS