NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

utils/size-stats-compare: clarify meaning of variables in print_result

Browse Source 
print_result is juggling with entry[x][y] which is not very readable.
While a better solution would be to use a class and reference named
attributes, that would require some bigger changes in the script.

Instead, make a minimal improvement by assigning the entry[x][y] values to
intermediate variables. Store them in a dict for easy usage from a format
string.

Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
This commit is contained in:
Thomas De Schampheleire 2021-03-03 16:04:50 +01:00 committed by Arnout Vandecappelle (Essensium/Mind)
parent bebeb772eb
commit e9b1dffa5d
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
utils/size-stats-compare
View File

@ -77,9 +77,15 @@ def print_results(result, threshold):
# list_result is a list of tuples: (name, (flag, size difference))
for entry in sorted(list_result, key=lambda entry: entry[1][1]):
if threshold is not None and abs(entry[1][1]) <= threshold:
data = dict(
name=entry[0],
action=entry[1][0],
size=entry[1][1],
)
if threshold is not None and abs(data['size']) <= threshold:
continue
print('%12s %7s %s' % (entry[1][1], entry[1][0], entry[0]))
print('{size:12d} {action:7s} {name}'.format(**data))
# main #########################################################################