From df83eb7bc7965273ee02e68a84dc9ec7ad916628 Mon Sep 17 00:00:00 2001 From: Heiko Thiery Date: Sat, 13 Jul 2024 07:42:15 +0200 Subject: [PATCH] package/pkg-cmake: remove override of CMAKE_ASM_COMPILER CMAKE_ASM_COMPILER is supposed to point to a compiler wrapper (i.e. gcc), _not_ to as directly. If it is not set, it will use the value of CMAKE_C_COMPILER. That's exactly what we want, so there is no need to set CMAKE_ASM_COMPILER at all. For target, we don't set CMAKE_ASM_COMPILER either. Setting CMAKE_ASM_COMPILER leads to build failures for any package that actually tries to build .S files for the host - like llvm. This is why llvm has an override for it. Signed-off-by: Heiko Thiery Signed-off-by: Arnout Vandecappelle (cherry picked from commit 22af5f2939089b996aeda9ce072ab2f9b3ee6c2d) Signed-off-by: Peter Korsgaard --- package/pkg-cmake.mk | 1 - 1 file changed, 1 deletion(-) diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk index 8f391eb4c9..c7032312fb 100644 --- a/package/pkg-cmake.mk +++ b/package/pkg-cmake.mk @@ -147,7 +147,6 @@ define $(2)_CONFIGURE_CMDS -DCMAKE_CXX_FLAGS="$$(HOST_CXXFLAGS)" \ -DCMAKE_EXE_LINKER_FLAGS="$$(HOST_LDFLAGS)" \ -DCMAKE_SHARED_LINKER_FLAGS="$$(HOST_LDFLAGS)" \ - -DCMAKE_ASM_COMPILER="$$(HOSTAS)" \ -DCMAKE_C_COMPILER="$$(CMAKE_HOST_C_COMPILER)" \ -DCMAKE_CXX_COMPILER="$$(CMAKE_HOST_CXX_COMPILER)" \ $(if $$(CMAKE_HOST_C_COMPILER_LAUNCHER),\