From d9c2b374ec4c8224a7f7a2f4d1518f001684c403 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rapha=C3=ABl=20M=C3=A9lotte?= Date: Fri, 7 Jun 2024 18:32:04 +0200 Subject: [PATCH] package/mupdf: fix building shared libraries MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit By default mupdf generates static libraries, shared libraries must be enabled explicitely. Also, when building shared libraries, mupdf's Makefile properly passes -fPIC, so adding it manually to MUPDF_CFLAGS is not needed. Signed-off-by: Raphaël Mélotte Signed-off-by: Thomas Petazzoni (cherry picked from commit 401162d4a947184654d8202392425a625d000172) Signed-off-by: Peter Korsgaard --- package/mupdf/mupdf.mk | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/package/mupdf/mupdf.mk b/package/mupdf/mupdf.mk index 4aef0f99e7..e3fe66e396 100644 --- a/package/mupdf/mupdf.mk +++ b/package/mupdf/mupdf.mk @@ -23,8 +23,7 @@ MUPDF_DEPENDENCIES = \ zlib MUPDF_CFLAGS = \ - $(TARGET_CFLAGS) \ - -fPIC # -fPIC is needed because the Makefile doesn't append it. + $(TARGET_CFLAGS) MUPDF_LDFLAGS = \ $(TARGET_LDFLAGS) @@ -40,6 +39,12 @@ MUPDF_MAKE_OPTS = \ HAVE_OBJCOPY=no \ prefix="/usr" +ifeq ($(BR2_STATIC_LIBS),y) +MUPDF_MAKE_OPTS += shared=no +else +MUPDF_MAKE_OPTS += shared=yes +endif + ifeq ($(BR2_PACKAGE_LIBFREEGLUT),y) MUPDF_DEPENDENCIES += libfreeglut else