From d7749ec247c7865b20ac4dd8bf63cc8e0902750f Mon Sep 17 00:00:00 2001 From: Thomas Petazzoni Date: Sun, 14 Oct 2018 21:11:58 +0200 Subject: [PATCH] boot/uboot: fix environment image generation on big endian systems As reported by Jeff Wittrock in bug #11396, the U-Boot environment image checksum is invalid for big endian targets, because the test on the BR2_ENDIAN Config.in option doesn't take into account that it is double quoted. The fix was provided by Jeff himself on bugzilla. Fixes bug #11396. Reported-by: Jeff Wittrock Signed-off-by: Thomas Petazzoni (cherry picked from commit d6fcf044a747284df4eddaf106082ebb571976b3) Signed-off-by: Peter Korsgaard --- boot/uboot/uboot.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk index 451f8c5d72..ae50a64c81 100644 --- a/boot/uboot/uboot.mk +++ b/boot/uboot/uboot.mk @@ -263,7 +263,7 @@ define UBOOT_GENERATE_ENV_IMAGE >$(@D)/buildroot-env.txt $(HOST_DIR)/bin/mkenvimage -s $(BR2_TARGET_UBOOT_ENVIMAGE_SIZE) \ $(if $(BR2_TARGET_UBOOT_ENVIMAGE_REDUNDANT),-r) \ - $(if $(filter BIG,$(BR2_ENDIAN)),-b) \ + $(if $(filter "BIG",$(BR2_ENDIAN)),-b) \ -o $(BINARIES_DIR)/uboot-env.bin \ $(@D)/buildroot-env.txt endef