From c5ffe830f3bb8cadea7491b94f140ba6bd3d0486 Mon Sep 17 00:00:00 2001 From: Fabrice Fontaine Date: Thu, 9 Jun 2022 23:25:10 +0200 Subject: [PATCH] package/noip: fix static build Pass TARGET_LDFLAGS (which will contain -static) through LIBS (as LDFLAGS is not supported) to fix the following static build failure (e.g. with musl): /home/autobuild/autobuild/instance-15/output-1/host/lib/gcc/microblazeel-buildroot-linux-musl/10.3.0/../../../../microblazeel-buildroot-linux-musl/bin/ld: /home/autobuild/autobuild/instance-15/output-1/host/lib/gcc/microblazeel-buildroot-linux-musl/10.3.0/libgcc.a(unwind-dw2.o): in function `__gthread_once': /home/autobuild/autobuild/instance-15/output-1/build/host-gcc-final-10.3.0/build/microblazeel-buildroot-linux-musl/libgcc/gthr-default.h:700: undefined reference to `pthread_once' While at it, also pass TARGET_CFLAGS through LIBS as suggested by Thomas Petazzoni Fixes: - http://autobuild.buildroot.org/results/5ea9b1b976aecc401e0aff21eef3e31c8ed17181 Signed-off-by: Fabrice Fontaine [Arnout: remove CPPFLAGS, already in CFLAGS] Signed-off-by: Arnout Vandecappelle (Essensium/Mind) --- package/noip/noip.mk | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/package/noip/noip.mk b/package/noip/noip.mk index b7fcc84e2f..8b57d82469 100644 --- a/package/noip/noip.mk +++ b/package/noip/noip.mk @@ -10,10 +10,13 @@ NOIP_SOURCE = noip-duc-linux.tar.gz NOIP_LICENSE = GPL-2.0+ NOIP_LICENSE_FILES = COPYING +# Pass TARGET_{C,LD}FLAGS through LIBS as noip doesn't rely on implicit +# make rules define NOIP_BUILD_CMDS $(SED) "/^#define CONFIG_FILENAME/ s/PREFIX//" $(@D)/noip2.c $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CC="$(TARGET_CC)" \ - CFLAGS="$(TARGET_CFLAGS)" PREFIX=/usr CONFDIR=/etc + LIBS="$(TARGET_CFLAGS) $(TARGET_LDFLAGS)" \ + PREFIX=/usr CONFDIR=/etc endef define NOIP_INSTALL_TARGET_CMDS