From bdc97b988cfb1c12efce3488bd8aab05a8800674 Mon Sep 17 00:00:00 2001 From: Andreas Ziegler Date: Sun, 6 Aug 2023 22:08:29 +0200 Subject: [PATCH] package/mpd: ensure expat is enabled when BR2_PACKAGE_MPD_UPNP_NPUPNP=y Just like BR2_PACKAGE_MPD_UPNP_PUPNP needs expat and curl support, BR2_PACKAGE_MPD_UPNP_NPUPNP also needs expat and curl. curl was already selected, but not expat. It didn't cause any visible issue, as BR2_PACKAGE_MPD_UPNP_NPUPNP selects BR2_PACKAGE_LIBNPUPNP, which itself select BR2_PACKAGE_EXPAT. But as mpd directly checks for the availability of expat, it makes sense to also select it directly. Signed-off-by: Andreas Ziegler [Thomas: extracted from a larger patch at https://patchwork.ozlabs.org/project/buildroot/patch/20221005091032.3014-5-br015@umbiko.net/] Signed-off-by: Thomas Petazzoni (cherry picked from commit 6cdb48a0482a093dcdf73d0d748f5435262515ab) Signed-off-by: Peter Korsgaard --- package/mpd/Config.in | 1 + package/mpd/mpd.mk | 1 + 2 files changed, 2 insertions(+) diff --git a/package/mpd/Config.in b/package/mpd/Config.in index f350b7e72a..902a3da779 100644 --- a/package/mpd/Config.in +++ b/package/mpd/Config.in @@ -407,6 +407,7 @@ config BR2_PACKAGE_MPD_UPNP_PUPNP config BR2_PACKAGE_MPD_UPNP_NPUPNP bool "npupnp" + select BR2_PACKAGE_EXPAT select BR2_PACKAGE_LIBNPUPNP select BR2_PACKAGE_MPD_CURL help diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk index 0205208946..4b737c715c 100644 --- a/package/mpd/mpd.mk +++ b/package/mpd/mpd.mk @@ -312,6 +312,7 @@ MPD_DEPENDENCIES += \ MPD_CONF_OPTS += -Dupnp=pupnp else ifeq ($(BR2_PACKAGE_MPD_UPNP_NPUPNP),y) MPD_DEPENDENCIES += \ + expat \ libnpupnp MPD_CONF_OPTS += -Dupnp=npupnp else ifeq ($(BR2_PACKAGE_MPD_UPNP_DISABLED),y)