From b717880f1fb7728648a2426dc20c3985fa3c530b Mon Sep 17 00:00:00 2001
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
Date: Sun, 14 Aug 2022 15:29:01 +0200
Subject: [PATCH] paclage/ace: explain why we use C+ pre-processor flags for
 C++ flags

Commit e8011a08b6fd (package/ace: needs C++11) did not explain why it
passed C++ flags via the pre-processor flags rather than as C++ flags
(via ACE's CCFLAGS).

This caused some head-scratching when reviewing and applying
803247337d35 (package/ace: fix build failure due to gcc bug 101915).

Add a comment to try and explain the non-standard use of pre-processor
flags to pass actual C++ flags.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc; Weber, Matthew L Collins <Matthew.Weber@collins.com>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/ace/ace.mk | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/ace/ace.mk b/package/ace/ace.mk
index e67e597bbe..3f7fe5e994 100644
--- a/package/ace/ace.mk
+++ b/package/ace/ace.mk
@@ -23,6 +23,9 @@ ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_101915),y)
 ACE_CPPFLAGS += -O0
 endif
 
+# ACE uses DEFFLAGS as C++ pre-processor flags, and CCFLAGS as the C++ flags.
+# Ace passes the pre-processor flags after the C++ flags, so we pass our
+# C++ flags as pre-processor flags, via DEFFLAGS.
 ACE_MAKE_OPTS = \
 	ACE_ROOT="$(@D)" \
 	DEFFLAGS="$(ACE_CPPFLAGS)"