From b6a4453bd7352d3bb27aef565d9023a1d11209c9 Mon Sep 17 00:00:00 2001 From: Fabrice Fontaine Date: Wed, 9 Mar 2022 00:17:33 +0100 Subject: [PATCH] package/dnsmasq: fix dnssec static build Drop -DHAVE_DNSSEC_STATIC which has been added by commit e913527b94e2e47b4ea6fcf13e281d5969f54fd6 but is not needed and raises the following static build failure because dnsmasq will wrongly append "-Wl,-Bstatic -lgmp -Wl,-Bdynamic": /home/buildroot/autobuild/instance-2/output-1/host/bin/x86_64-linux-gcc -static -o dnsmasq cache.o rfc1035.o util.o option.o forward.o network.o dnsmasq.o dhcp.o lease.o rfc2131.o netlink.o dbus.o bpf.o helper.o tftp.o log.o conntrack.o dhcp6.o rfc3315.o dhcp-common.o outpacket.o radv.o slaac.o auth.o ipset.o pattern.o domain.o dnssec.o blockdata.o tables.o loop.o inotify.o poll.o rrfilter.o edns0.o arp.o crypto.o dump.o ubus.o metrics.o hash-questions.o domain-match.o -Wl,-Bstatic -L/home/buildroot/autobuild/instance-2/output-1/host/bin/../x86_64-buildroot-linux-musl/sysroot/usr/lib -lhogweed -lgmp -lnettle -Wl,-Bdynamic -Wl,-Bstatic -lgmp -Wl,-Bdynamic /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/x86_64-buildroot-linux-musl/10.3.0/../../../../x86_64-buildroot-linux-musl/bin/ld: attempted static link of dynamic object `/home/buildroot/autobuild/instance-2/output-1/host/x86_64-buildroot-linux-musl/sysroot/lib/../lib64/libc.so' Strangely enough, this is the first time this build failure is raised by the autobuilders whereas "-Wl,-Bdynamic" is set since a very long time: https://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=c979fa04a40ff12370c8d3a82ad27d9d3b5907e3 Fixes: - http://autobuild.buildroot.org/results/99b419ddb5a3be561d39e715833510a59519213e Signed-off-by: Fabrice Fontaine Signed-off-by: Arnout Vandecappelle (Essensium/Mind) --- package/dnsmasq/dnsmasq.mk | 3 --- 1 file changed, 3 deletions(-) diff --git a/package/dnsmasq/dnsmasq.mk b/package/dnsmasq/dnsmasq.mk index 0569475fc4..230e4a8116 100644 --- a/package/dnsmasq/dnsmasq.mk +++ b/package/dnsmasq/dnsmasq.mk @@ -26,9 +26,6 @@ endif ifeq ($(BR2_PACKAGE_DNSMASQ_DNSSEC),y) DNSMASQ_DEPENDENCIES += gmp nettle DNSMASQ_COPTS += -DHAVE_DNSSEC -ifeq ($(BR2_STATIC_LIBS),y) -DNSMASQ_COPTS += -DHAVE_DNSSEC_STATIC -endif endif ifneq ($(BR2_PACKAGE_DNSMASQ_TFTP),y)