NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

package/valgrind: hide comment when arch is not supported

Browse Source 
Currently, the comment that "valgrind needs shared libs" is not hidden
when the architecture dependencies are not met, which can confuse some
users (as recently seen on IRC).

Fix that by introducing the traditional _ARCH_SUPPORTS option, and have
the comment and the symbol depend on that.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Brandon Maier <brandon.maier@rockwellcollins.com>
Cc: Jérôme Pouiller <jezz@sysmic.org>
Cc: Peter Seiderer <ps.report@gmx.net>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Reviewed--by: Pedro Ribeiro <pedrib@gmail.com>
Tested-by: Pedro Ribeiro <pedrib@gmail.com>
[Arnout: put _ARCH_SUPPORTS at the top of the file]
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
This commit is contained in:
Yann E. MORIN 2017-08-10 23:51:11 +02:00 committed by Arnout Vandecappelle (Essensium/Mind)
parent e4f7ec4bd1
commit afb6bc67a6
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
package/valgrind/Config.in
View File

@ -1,14 +1,19 @@
config BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
bool
default y if BR2_ARM_CPU_ARMV7A
default y if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
default y if BR2_i386 || BR2_x86_64
default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
depends on !BR2_MIPS_SOFT_FLOAT
comment "valgrind needs a toolchain w/ dynamic library" comment "valgrind needs a toolchain w/ dynamic library"
depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
depends on BR2_STATIC_LIBS depends on BR2_STATIC_LIBS
config BR2_PACKAGE_VALGRIND config BR2_PACKAGE_VALGRIND
bool "valgrind" bool "valgrind"
depends on BR2_ARM_CPU_ARMV7A || BR2_i386 || \ depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \
BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
BR2_x86_64
depends on !BR2_STATIC_LIBS depends on !BR2_STATIC_LIBS
depends on !BR2_MIPS_SOFT_FLOAT
help help
Tool for debugging and profiling Linux programs. Tool for debugging and profiling Linux programs.