From ade4f4b4e5e5257d7fca57863a7ef293c62bb343 Mon Sep 17 00:00:00 2001 From: Peter Korsgaard Date: Wed, 15 Jan 2025 17:33:09 +0100 Subject: [PATCH] package/rsync: security bump to version 3.4.0 Release note: https://download.samba.org/pub/rsync/NEWS#3.4.0 Fixes the following vulnerabilities: CVE-2024-12084: Heap Buffer Overflow in Rsync due to Improper Checksum Length Handling Description: A heap-based buffer overflow flaw was found in the rsync daemon. This issue is due to improper handling of attacker-controlled checksum lengths (s2length) in the code. When MAX_DIGEST_LEN exceeds the fixed SUM_LENGTH (16 bytes), an attacker can write out of bounds in the sum2 buffer. CVE-2024-12085: Info Leak via Uninitialized Stack Contents Description: A flaw was found in the rsync daemon which could be triggered when rsync compares file checksums. This flaw allows an attacker to manipulate the checksum length (s2length) to cause a comparison between a checksum and uninitialized memory and leak one byte of uninitialized stack data at a time. CVE-2024-12086: Rsync Server Leaks Arbitrary Client Files Description: A flaw was found in rsync. It could allow a server to enumerate the contents of an arbitrary file from the client's machine. This issue occurs when files are being copied from a client to a server. During this process, the rsync server will send checksums of local data to the client to compare with in order to determine what data needs to be sent to the server. By sending specially constructed checksum values for arbitrary files, an attacker may be able to reconstruct the data of those files byte-by-byte based on the responses from the client. CVE-2024-12087: Path Traversal Vulnerability in Rsync Description: A path traversal vulnerability exists in rsync. It stems from behavior enabled by the `--inc-recursive` option, a default-enabled option for many client options and can be enabled by the server even if not explicitly enabled by the client. When using the `--inc-recursive` option, a lack of proper symlink verification coupled with deduplication checks occurring on a per-file-list basis could allow a server to write files outside of the client's intended destination directory. A malicious server could write malicious files to arbitrary locations named after valid directories/paths on the client. CVE-2024-12088: --safe-links Option Bypass Leads to Path Traversal Description: A flaw was found in rsync. When using the `--safe-links` option, rsync fails to properly verify if a symbolic link destination contains another symbolic link within it. This results in a path traversal vulnerability, which may lead to arbitrary file write outside the desired directory. CVE-2024-12747: Race Condition in Rsync Handling Symbolic Links Description: A flaw was found in rsync. This vulnerability arises from a race condition during rsync's handling of symbolic links. Rsync's default behavior when encountering symbolic links is to skip them. If an attacker replaced a regular file with a symbolic link at the right time, it was possible to bypass the default behavior and traverse symbolic links. Depending on the privileges of the rsync process, an attacker could leak sensitive information, potentially leading to privilege escalation. For more details, see the advisory: https://www.openwall.com/lists/oss-security/2025/01/14/3 Signed-off-by: Peter Korsgaard [Julien: add link to release note] Signed-off-by: Julien Olivain (cherry picked from commit 017d74c943a03c7b36ef7d71886b29b27d817c12) Signed-off-by: Peter Korsgaard --- package/rsync/rsync.hash | 4 ++-- package/rsync/rsync.mk | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package/rsync/rsync.hash b/package/rsync/rsync.hash index edeca9c4df..336d785153 100644 --- a/package/rsync/rsync.hash +++ b/package/rsync/rsync.hash @@ -1,5 +1,5 @@ # Locally calculated after checking pgp signature -# https://rsync.samba.org/ftp/rsync/src/rsync-3.3.0.tar.gz.asc -sha256 7399e9a6708c32d678a72a63219e96f23be0be2336e50fd1348498d07041df90 rsync-3.3.0.tar.gz +# https://rsync.samba.org/ftp/rsync/src/rsync-3.4.0.tar.gz.asc +sha256 8e942f95a44226a012fe822faffa6c7fc38c34047add3a0c941e9bc8b8b93aa4 rsync-3.4.0.tar.gz # Locally calculated sha256 85c19ea50a224c2d0067a69c083584e5717b40b76610ec1218f91385775067dd COPYING diff --git a/package/rsync/rsync.mk b/package/rsync/rsync.mk index 188c87e1d4..4613778a7f 100644 --- a/package/rsync/rsync.mk +++ b/package/rsync/rsync.mk @@ -4,7 +4,7 @@ # ################################################################################ -RSYNC_VERSION = 3.3.0 +RSYNC_VERSION = 3.4.0 RSYNC_SITE = https://rsync.samba.org/ftp/rsync/src RSYNC_LICENSE = GPL-3.0+ with exceptions RSYNC_LICENSE_FILES = COPYING