NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

toolchain/toolchain-buildroot: add comment about using virtual package infra

Browse Source 
Commit "9a8ec9195c toolchain/toolchain-buildroot: migrate to virtual
package infrastructure" made the packages toolchain and
toolchain-buildroot to use the virtual package infra even they being
generic packages.
This works because on package/pkg-virtual.mk when a package do not
define neither _PROVIDES_ or _HAS_ symbols, only _IS_VIRTUAL is set to
YES and _VERSION and _SOURCE are set to empty before relaying the call
to inner-generic-package.

Add a comment explaining why the virtual package infra is used in these
cases.

Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Romain Naour <romain.naour@gmail.com>
Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Yann E. MORIN <yann.morin.1998@free.fr>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
This commit is contained in:
Ricardo Martincoski 2022-11-27 10:07:27 -03:00 committed by Peter Korsgaard
parent 29c9b44355
commit abcecd737b
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
toolchain/toolchain-buildroot/toolchain-buildroot.mk
View File

@ -14,4 +14,7 @@ TOOLCHAIN_BUILDROOT_DEPENDENCIES = host-gcc-final
TOOLCHAIN_BUILDROOT_ADD_TOOLCHAIN_DEPENDENCY = NO TOOLCHAIN_BUILDROOT_ADD_TOOLCHAIN_DEPENDENCY = NO
# Not really a virtual package, but we use the virtual package infra here so
# both the build log and build directory look nicer (toolchain-buildroot-virtual
# instead of toolchain-buildroot-undefined)
$(eval $(virtual-package)) $(eval $(virtual-package))

3
toolchain/toolchain/toolchain.mk
View File

@ -47,4 +47,7 @@ endef
TOOLCHAIN_POST_INSTALL_TARGET_HOOKS += TOOLCHAIN_GLIBC_COPY_NSSWITCH_FILE TOOLCHAIN_POST_INSTALL_TARGET_HOOKS += TOOLCHAIN_GLIBC_COPY_NSSWITCH_FILE
endif endif
# Not really a virtual package, but we use the virtual package infra here so
# both the build log and build directory look nicer (toolchain-virtual instead
# of toolchain-undefined)
$(eval $(virtual-package)) $(eval $(virtual-package))