NetCube-Systems-Austria/kumquat-buildroot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

legacy: update the BR2_PREFER_STATIC_LIB option

Browse Source 
Since the refactoring of the type of libraries in the target filesystem,
these options belong to a choice, and the default is "shared only".

The former option BR2_PREFER_STATIC_LIB has been moved in the legacy
menu, and only selects the BR2_STATIC_LIBS ("static only") option.
However, because BR2_STATIC_LIBS belongs to a choice, when
BR2_PREFER_STATIC_LIB is selected, it does not affect the choice.
So, existing Buildroot configurations, which have BR2_PREFER_STATIC_LIB
set, will silently end with BR2_SHARED_LIBS ("shared only") enabled.

So, the backward compatibility is not kept.

Besides, the legacy BR2_PREFER_STATIC_LIB option does not select
BR2_LEGACY, so the user is not notified of this legacy option, and the
build silently continues with some undesired changes.

This patch removes the inefficient BR2_STATIC_LIBS selection, correctly
selects the BR2_LEGACY option and extend the help message so the user
can easily know how to update his/her Buildroot configuration.

Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
This commit is contained in:
Samuel Martin 2014-12-14 17:24:24 +01:00 committed by Peter Korsgaard
parent a21163aed9
commit a44b1c1405
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Config.in.legacy
View File

@ -104,13 +104,16 @@ comment "Legacy options removed in 2015.02"
config BR2_PREFER_STATIC_LIB
bool "static library option renamed"
select BR2_STATIC_LIBS
select BR2_LEGACY
help
The BR2_PREFER_STATIC_LIB was renamed to BR2_STATIC_LIBS. It
highlights the fact that the option no longer "prefers"
static libraries, but "enforces" static libraries (i.e
shared libraries are completely unused).
Take care of updating the type of libraries you want under the
"Build options" menu.
comment "Legacy options removed in 2014.11"
config BR2_x86_generic